You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/08/15 02:24:16 UTC
Review Request 24722: Make sure the mesos-fetcher exits if the slave
terminates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/
-----------------------------------------------------------
Review request for mesos, Ian Downes and Jie Yu.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 1f458970081639db50d07c4ca67765a8b0903978
src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1
Diff: https://reviews.apache.org/r/24722/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24722: Make sure the mesos-fetcher exits if the
slave terminates.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/#review50793
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Aug. 15, 2014, 11:30 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24722/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 11:30 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1
> src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
>
> Diff: https://reviews.apache.org/r/24722/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24722: Make sure the mesos-fetcher exits if the
slave terminates.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 16, 2014, 2:52 a.m., Benjamin Hindman wrote:
> > Re-opened for review as a slave that was launched with the environment variable LIBPROCESS_PORT will cause the mesos-fetcher to fail to start because it also tries to bind to that port.
>
> Jie Yu wrote:
> hum, does that even affect the mesos containerizer?
Yes, so I'll likely be reverting. This wasn't critical for the 0.20.0 release, just a nice to have.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/#review50812
-----------------------------------------------------------
On Aug. 15, 2014, 11:43 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24722/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 11:43 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1
> src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
>
> Diff: https://reviews.apache.org/r/24722/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24722: Make sure the mesos-fetcher exits if the
slave terminates.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 16, 2014, 2:52 a.m., Benjamin Hindman wrote:
> > Re-opened for review as a slave that was launched with the environment variable LIBPROCESS_PORT will cause the mesos-fetcher to fail to start because it also tries to bind to that port.
hum, does that even affect the mesos containerizer?
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/#review50812
-----------------------------------------------------------
On Aug. 15, 2014, 11:43 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24722/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 11:43 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1
> src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
>
> Diff: https://reviews.apache.org/r/24722/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24722: Make sure the mesos-fetcher exits if the
slave terminates.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/#review50812
-----------------------------------------------------------
Re-opened for review as a slave that was launched with the environment variable LIBPROCESS_PORT will cause the mesos-fetcher to fail to start because it also tries to bind to that port.
- Benjamin Hindman
On Aug. 15, 2014, 11:43 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24722/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 11:43 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1
> src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
>
> Diff: https://reviews.apache.org/r/24722/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24722: Make sure the mesos-fetcher exits if the
slave terminates.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/
-----------------------------------------------------------
(Updated Aug. 15, 2014, 11:43 p.m.)
Review request for mesos, Ian Downes and Jie Yu.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1
src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
Diff: https://reviews.apache.org/r/24722/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24722: Make sure the mesos-fetcher exits if the
slave terminates.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/
-----------------------------------------------------------
(Updated Aug. 15, 2014, 11:30 p.m.)
Review request for mesos, Ian Downes and Jie Yu.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1
src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
Diff: https://reviews.apache.org/r/24722/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24722: Make sure the mesos-fetcher exits if the
slave terminates.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/#review50673
-----------------------------------------------------------
Ship it!
src/launcher/fetcher.cpp
<https://reviews.apache.org/r/24722/#comment88534>
Some process might be forking, so we might miss some processes here, right? Adding a TODO?
src/launcher/fetcher.cpp
<https://reviews.apache.org/r/24722/#comment88533>
s/stdin/STDIN_FILENO/?
- Jie Yu
On Aug. 15, 2014, 12:26 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24722/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 12:26 a.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 1f458970081639db50d07c4ca67765a8b0903978
> src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1
> src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
>
> Diff: https://reviews.apache.org/r/24722/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24722: Make sure the mesos-fetcher exits if the
slave terminates.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/#review50687
-----------------------------------------------------------
Ship it!
src/launcher/fetcher.cpp
<https://reviews.apache.org/r/24722/#comment88550>
s/the the/the/
src/launcher/fetcher.cpp
<https://reviews.apache.org/r/24722/#comment88551>
s/it's/its/
- Ian Downes
On Aug. 14, 2014, 5:26 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24722/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2014, 5:26 p.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 1f458970081639db50d07c4ca67765a8b0903978
> src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1
> src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
>
> Diff: https://reviews.apache.org/r/24722/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24722: Make sure the mesos-fetcher exits if the
slave terminates.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/#review50681
-----------------------------------------------------------
src/launcher/fetcher.cpp
<https://reviews.apache.org/r/24722/#comment88544>
Nit: We've been using SIGKILL instead of 9 in the code base.
- Timothy Chen
On Aug. 15, 2014, 12:26 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24722/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2014, 12:26 a.m.)
>
>
> Review request for mesos, Ian Downes and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 1f458970081639db50d07c4ca67765a8b0903978
> src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1
> src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
>
> Diff: https://reviews.apache.org/r/24722/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24722: Make sure the mesos-fetcher exits if the
slave terminates.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24722/
-----------------------------------------------------------
(Updated Aug. 15, 2014, 12:26 a.m.)
Review request for mesos, Ian Downes and Jie Yu.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 1f458970081639db50d07c4ca67765a8b0903978
src/launcher/fetcher.cpp 50e991840b542e98b1b2870699b45505d4cf75f1
src/slave/containerizer/mesos/containerizer.cpp d0676c55e3bb30bcc8e32b27c091080ec58b0c81
Diff: https://reviews.apache.org/r/24722/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman