You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "zhijiang (Jira)" <ji...@apache.org> on 2020/01/21 09:38:00 UTC

[jira] [Closed] (FLINK-15444) Make the component AbstractInvokable in CheckpointBarrierHandler NonNull

     [ https://issues.apache.org/jira/browse/FLINK-15444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhijiang closed FLINK-15444.
----------------------------
    Resolution: Fixed

Merged in master : 9f92ddfecad6e056cc4b58311e493cbb0884357b

> Make the component AbstractInvokable in CheckpointBarrierHandler NonNull 
> -------------------------------------------------------------------------
>
>                 Key: FLINK-15444
>                 URL: https://issues.apache.org/jira/browse/FLINK-15444
>             Project: Flink
>          Issue Type: Task
>          Components: Runtime / Checkpointing
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The current component {{AbstractInvokable}} in {{CheckpointBarrierHandler}} is annotated as {{@Nullable}}. Actually in real code path it is passed via the constructor and never be null. The nullable annotation is only used for unit test purpose. But this way would mislead the real usage in practice and bring extra troubles, because you have to alway check whether it is null before usage in related processes.
> We can refactor the related unit tests to implement a dummy {{AbstractInvokable}} for tests and remove the {{@Nullable}} annotation from the related class constructors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)