You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by aroberson <gi...@git.apache.org> on 2015/06/18 20:59:46 UTC
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
GitHub user aroberson opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/119
Fixed NullPointer Exception in Android 5 due to invalid column name on cursor
http://stackoverflow.com/questions/30640251/cordova-resolvelocalfilesystemurl-error-code-1000-in-android/30923570#30923570
Was getting this when trying to retrieve the last modified date.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ABB-Austin/cordova-plugin-file master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #119
----
commit 536c795c6ccfe57615ccb6eb7433498cd36c94c4
Author: aroberson <ad...@ventyx.abb.com>
Date: 2015-06-18T18:52:01Z
Fixed NullPointer Exception in Android 5 and above due to invalid column name on cursor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154187370
Can you create a JIRA issue for this, so I know what I'm testing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#discussion_r44106504
--- Diff: src/android/ContentFilesystem.java ---
@@ -18,22 +18,19 @@ Licensed to the Apache Software Foundation (ASF) under one
*/
package org.apache.cordova.file;
-import java.io.File;
-import java.io.FileNotFoundException;
-import java.io.IOException;
-import java.io.OutputStream;
-
-import org.apache.cordova.CordovaResourceApi;
-import org.json.JSONArray;
-import org.json.JSONException;
-import org.json.JSONObject;
-
import android.content.ContentResolver;
import android.content.Context;
import android.database.Cursor;
import android.net.Uri;
+import android.provider.DocumentsContract;
import android.provider.MediaStore;
import android.provider.OpenableColumns;
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import org.apache.cordova.CordovaResourceApi;
+import org.json.JSONException;
+import org.json.JSONObject;
--- End diff --
LULZ! They follow the "Android Studio/Eclipse put it there for me style".
Seriously, Cordova, Android and Java imports should be grouped separately, but I'm not completely concerned about the order of the groupings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Posted by didlich <gi...@git.apache.org>.
Github user didlich commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154184039
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154577821
I think we need @aroberson to sign and submit an ICLA https://www.apache.org/licenses/icla.txt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Posted by jasongin <gi...@git.apache.org>.
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#discussion_r44084198
--- Diff: src/android/ContentFilesystem.java ---
@@ -18,22 +18,19 @@ Licensed to the Apache Software Foundation (ASF) under one
*/
package org.apache.cordova.file;
-import java.io.File;
-import java.io.FileNotFoundException;
-import java.io.IOException;
-import java.io.OutputStream;
-
-import org.apache.cordova.CordovaResourceApi;
-import org.json.JSONArray;
-import org.json.JSONException;
-import org.json.JSONObject;
-
import android.content.ContentResolver;
import android.content.Context;
import android.database.Cursor;
import android.net.Uri;
+import android.provider.DocumentsContract;
import android.provider.MediaStore;
import android.provider.OpenableColumns;
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import org.apache.cordova.CordovaResourceApi;
+import org.json.JSONException;
+import org.json.JSONObject;
--- End diff --
Please keep the import statements separated into groups. Ideally I think they should follow the [Android style](http://source.android.com/source/code-style.html#order-import-statements), but not all of Cordova's Android code follows that now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-155221640
Looks good here. Had to spend more time fixing camera issues than actually testing this PR. :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Posted by aroberson <gi...@git.apache.org>.
Github user aroberson commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154613677
I filled it out and sent it to the secretary.
Thanks,
Adam Roberson
On 11/6/15 5:38 PM, Steve Gill wrote:
>
> I think we need @aroberson <https://github.com/aroberson> to sign and
> submit an ICLA https://www.apache.org/licenses/icla.txt
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154577821>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Posted by cjpearson <gi...@git.apache.org>.
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154181249
@infil00p, could you take a look at this PR? I'm running into this issue when I try to open a file that was taken from the camera plugin on Android Lollipop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Posted by jasongin <gi...@git.apache.org>.
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154226660
Looks good to me other than the minor style issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Posted by aroberson <gi...@git.apache.org>.
Github user aroberson commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154581790
I will get to this tonight.
> On Nov 6, 2015, at 5:38 PM, Steve Gill <no...@github.com> wrote:
>
> I think we need @aroberson to sign and submit an ICLA https://www.apache.org/licenses/icla.txt
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Posted by cjpearson <gi...@git.apache.org>.
Github user cjpearson commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154190076
https://issues.apache.org/jira/browse/CB-9965
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org