You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/30 09:20:14 UTC

[GitHub] [shardingsphere] gxxiong commented on a diff in pull request #22494: Optimize algorithmDefinition naming in encryptColumnDefinition

gxxiong commented on code in PR #22494:
URL: https://github.com/apache/shardingsphere/pull/22494#discussion_r1035717445


##########
features/encrypt/distsql/parser/src/main/antlr4/imports/encrypt/RDLStatement.g4:
##########
@@ -44,7 +44,7 @@ resourceName
     ;
 
 encryptColumnDefinition
-    : LP columnDefinition (COMMA plainColumnDefinition)? COMMA cipherColumnDefinition (COMMA assistedQueryColumnDefinition)? (COMMA likeQueryColumnDefinition)? COMMA algorithmDefinition (COMMA algorithmDefinition)? (COMMA algorithmDefinition)? RP
+    : LP columnDefinition (COMMA plainColumnDefinition)? COMMA cipherColumnDefinition (COMMA assistedQueryColumnDefinition)? (COMMA likeQueryColumnDefinition)? COMMA cipherAlgorithm (COMMA assistedAlgorithm)? (COMMA likeAlgorithm)? RP

Review Comment:
   encryptAlgorithm
       : ENCRYPT_ALGORITHM LP algorithmDefinition RP
       ;
   
   assistedQueryAlgorithm
       : ASSISTED_QUERY_ALGORITHM LP algorithmDefinition RP
       ;
   
   likeQueryAlgorithm
       : LIKE_QUERY_ALGORITHM LP algorithmDefinition RP
       ;
   Modified like this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org