You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Michael Becke <be...@u.washington.edu> on 2003/03/05 16:06:42 UTC
Re: cvs commit: jakarta-commons/httpclient/src/test/org/apache/commons/httpclient
I agree, some splitting into packages would be good. Along these lines
I was thinking of renaming all of the localhost test to just host. The
test host could really be anywhere.
Mike
Kalnichevski, Oleg wrote:
> Mike
>
> I think you have done the right things. If any problems surface, they can be dealt with on individual basis
>
> Jeff once complained about test package getting completely unwieldy, which is definitely the case. He suggested the test cases be better structured into sub-packages. This would be a reasonable thing to do. Probably we could split test cases along the established demarcation lines into no-host, local-host, and external packages as a fist step
>
> Cheers
>
> Oleg
>
> -----Original Message-----
> From: Michael Becke [mailto:becke@u.washington.edu]
> Sent: Wednesday, March 05, 2003 14:57
> To: Commons HttpClient Project
> Subject: Re: cvs commit:
> jakarta-commons/httpclient/src/test/org/apache/commons/httpclient
>
>
> Thanks Oleg. I had not realized how big this was until I committed the
> patch. I would have posted it for review if I had realized.
>
> I have some more plans for work in the test code. I will post some
> ideas before I get to work. Please let me know if you have any ideas
> about how we can improve our tests.
>
> Thanks,
>
> Mike
>
> On Wednesday, March 5, 2003, at 03:39 AM, Kalnichevski, Oleg wrote:
>
>
>>Mike
>>This is massive!!! It's a much needed and welcome refactoring. Many
>>thanks for this work
>>Oleg
>>
>>-----Original Message-----
>>From: Michael Becke [mailto:becke@u.washington.edu]
>>Sent: Mittwoch, 5. März 2003 05:34
>>To: Commons Project
>>Subject: cvs commit:
>>jakarta-commons/httpclient/src/test/org/apache/commons/httpclient
>>
>>
>>Below is a forward of a CVS commit I posted to the test directory a few
>>minutes ago. It was rejected by the jakarta-commons-cvs mailing list
>>as it was over 100KB. I had not realized it was so large. The diffs
>>have been removed to reduce size.
>>
>>Mike
>>
>>
>>>mbecke 2003/03/04 20:02:57
>>>
>>> Modified: httpclient/src/test/org/apache/commons/httpclient
>>> TestHttpConnectionManager.java
>>> TestWebappBasicAuth.java
>>> TestWebappNoncompliant.java
>>> TestMethodsLocalHost.java
>>>TestWebappPostMethod.java
>>> TestGetMethodLocal.java TestLocalHostBase.java
>>> TestWebappCookie.java TestLocalHost.java
>>> TestWebappMultiPostMethod.java
>>> TestWebappParameters.java
>>>TestTraceMethodLocal.java
>>> TestWebappBase.java TestWebappMethods.java
>>> TestHttpConnection.java
>>>TestWebappRedirect.java
>>> TestWebappHeaders.java
>>> Added: httpclient/src/test/org/apache/commons/httpclient
>>> ExecuteMethodThread.java
>>> Removed: httpclient/src/test/org/apache/commons/httpclient
>>> TestHttpClientLocalHost.java
>>> Log:
>>> Refactored localhost tests. All tests that access the localhost now
>>>subclass TestLocalHostBase. This way there is only once place that
>>>configures an HttpClient instance. This will be useful if we want to
>>>test against hosts other that localhost and if we want to test through
>>>a proxy or with https.
>>>
>>>Added multi-threaded test for HttpConnectionManager.
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail:
>>commons-httpclient-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail:
>>commons-httpclient-dev-help@jakarta.apache.org
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail:
>>commons-httpclient-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail:
>>commons-httpclient-dev-help@jakarta.apache.org
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org
>
Re: cvs commit: jakarta-commons/httpclient/src/test/org/apache/commons/httpclient
Posted by Michael Becke <be...@u.washington.edu>.
Jeffrey Dever wrote:
> We really have 3 different type of tests:
> nohost: those that run entirely within the test JVM
> remote: those that hit some number public internet resources
> webapp: those that require the httpclient .war deployed in a container
Yes, quite so.
> There is nothing special about the host that the webapp resides. A
particular host is just as good as localhost: its just a configuration
property (with localhost as the default). I could even see a point
where we had a public webapp server (like jakarta) that has release
versions of the .war deployed for the purpose of field testing. Then
any user that downoladed a release version of httpclient could run the
tests without further setup on their part.
A public site with the webapps deployed is a great idea. This could
also be used by Maven for the automated builds. Speaking of which, we
should probably also add the "localhost" tests to Maven.
Mike
Re: cvs commit: jakarta-commons/httpclient/src/test/org/apache/commons/httpclient
Posted by Michael Becke <be...@u.washington.edu>.
Jeffrey Dever wrote:
> We really have 3 different type of tests:
> nohost: those that run entirely within the test JVM
> remote: those that hit some number public internet resources
> webapp: those that require the httpclient .war deployed in a container
Yes, quite so.
> There is nothing special about the host that the webapp resides. A
> particular host is just as good as localhost: its just a configuration
> property (with localhost as the default). I could even see a point
> where we had a public webapp server (like jakarta) that has release
> versions of the .war deployed for the purpose of field testing. Then
> any user that downoladed a release version of httpclient could run the
> tests without further setup on their part.
A public site with the webapps deployed is a great idea. This could
also be used by Maven for the automated builds. Speaking of which, we
should probably also add the "localhost" tests to Maven.
Mike
Re: cvs commit: jakarta-commons/httpclient/src/test/org/apache/commons/httpclient
Posted by Jeffrey Dever <js...@sympatico.ca>.
We really have 3 different type of tests:
nohost: those that run entirely within the test JVM
remote: those that hit some number public internet resources
webapp: those that require the httpclient .war deployed in a container
There is nothing special about the host that the webapp resides. A
particular host is just as good as localhost: its just a configuration
property (with localhost as the default). I could even see a point
where we had a public webapp server (like jakarta) that has release
versions of the .war deployed for the purpose of field testing. Then
any user that downoladed a release version of httpclient could run the
tests without further setup on their part.
We can be very liberal in making changes to the test package. The files
are not "released" and are not subject to the versioning guidlines. Its
great to see a lot of attention paid to the tests. They make up a good
part of the quality statement for HttpClient.
Jandalf.
Michael Becke wrote:
> I agree, some splitting into packages would be good. Along these
> lines I was thinking of renaming all of the localhost test to just
> host. The test host could really be anywhere.
>
> Mike
>
> Kalnichevski, Oleg wrote:
>
>> Mike
>>
>> I think you have done the right things. If any problems surface, they
>> can be dealt with on individual basis
>>
>> Jeff once complained about test package getting completely unwieldy,
>> which is definitely the case. He suggested the test cases be better
>> structured into sub-packages. This would be a reasonable thing to do.
>> Probably we could split test cases along the established demarcation
>> lines into no-host, local-host, and external packages as a fist step
>>
>> Cheers
>>
>> Oleg
>>
>> -----Original Message-----
>> From: Michael Becke [mailto:becke@u.washington.edu]
>> Sent: Wednesday, March 05, 2003 14:57
>> To: Commons HttpClient Project
>> Subject: Re: cvs commit:
>> jakarta-commons/httpclient/src/test/org/apache/commons/httpclient
>>
>> Thanks Oleg. I had not realized how big this was until I committed
>> the patch. I would have posted it for review if I had realized.
>>
>> I have some more plans for work in the test code. I will post some
>> ideas before I get to work. Please let me know if you have any ideas
>> about how we can improve our tests.
>>
>> Thanks,
>>
>> Mike
>>
>> On Wednesday, March 5, 2003, at 03:39 AM, Kalnichevski, Oleg wrote:
>>
>>
>>> Mike
>>> This is massive!!! It's a much needed and welcome refactoring. Many
>>> thanks for this work
>>> Oleg
>>>
>>> -----Original Message-----
>>> From: Michael Becke [mailto:becke@u.washington.edu]
>>> Sent: Mittwoch, 5. März 2003 05:34
>>> To: Commons Project
>>> Subject: cvs commit:
>>> jakarta-commons/httpclient/src/test/org/apache/commons/httpclient
>>>
>>>
>>> Below is a forward of a CVS commit I posted to the test directory a few
>>> minutes ago. It was rejected by the jakarta-commons-cvs mailing list
>>> as it was over 100KB. I had not realized it was so large. The diffs
>>> have been removed to reduce size.
>>>
>>> Mike
>>>
>>>
>>>> mbecke 2003/03/04 20:02:57
>>>>
>>>> Modified: httpclient/src/test/org/apache/commons/httpclient
>>>> TestHttpConnectionManager.java
>>>> TestWebappBasicAuth.java
>>>> TestWebappNoncompliant.java
>>>> TestMethodsLocalHost.java
>>>> TestWebappPostMethod.java
>>>> TestGetMethodLocal.java TestLocalHostBase.java
>>>> TestWebappCookie.java TestLocalHost.java
>>>> TestWebappMultiPostMethod.java
>>>> TestWebappParameters.java
>>>> TestTraceMethodLocal.java
>>>> TestWebappBase.java TestWebappMethods.java
>>>> TestHttpConnection.java TestWebappRedirect.java
>>>> TestWebappHeaders.java
>>>> Added: httpclient/src/test/org/apache/commons/httpclient
>>>> ExecuteMethodThread.java
>>>> Removed: httpclient/src/test/org/apache/commons/httpclient
>>>> TestHttpClientLocalHost.java
>>>> Log:
>>>> Refactored localhost tests. All tests that access the localhost now
>>>> subclass TestLocalHostBase. This way there is only once place that
>>>> configures an HttpClient instance. This will be useful if we want to
>>>> test against hosts other that localhost and if we want to test through
>>>> a proxy or with https.
>>>>
>>>> Added multi-threaded test for HttpConnectionManager.
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail:
>>> commons-httpclient-dev-unsubscribe@jakarta.apache.org
>>> For additional commands, e-mail:
>>> commons-httpclient-dev-help@jakarta.apache.org
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail:
>>> commons-httpclient-dev-unsubscribe@jakarta.apache.org
>>> For additional commands, e-mail:
>>> commons-httpclient-dev-help@jakarta.apache.org
>>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail:
>> commons-httpclient-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail:
>> commons-httpclient-dev-help@jakarta.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail:
>> commons-httpclient-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail:
>> commons-httpclient-dev-help@jakarta.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> commons-httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail:
> commons-httpclient-dev-help@jakarta.apache.org
>
>