[GitHub] [spark] dongjoon-hyun commented on issue #24889: [SPARK-28072][SQL] Fix IncompatibleClassChangeError in `FromUnixTime` codegen on JDK9+

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on issue #24889: [SPARK-28072][SQL] Fix IncompatibleClassChangeError in `FromUnixTime` codegen on JDK9+
URL: https://github.com/apache/spark/pull/24889#issuecomment-502938150
 
 
   Hi, @cloud-fan , @srowen , @MaxGekk .
   This PR(title/description/content) is updated with @cloud-fan 's suggestion which replaces `$tf.apply` with `$tf$$.MODULE$$.apply`. Initially, I thought we don't have a test coverage for the other two cases which @MaxGekk pointed, but we have one test coverage for that. The implementation was correct, so it passed in JDK11. I added only one additional test coverage and add `SPARK-28072` to the relevant test code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org