You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/04/12 15:06:03 UTC
[GitHub] [arrow] zeroshade opened a new pull request, #35077: GH-35062: [Go][CI] Fix verification failures
zeroshade opened a new pull request, #35077:
URL: https://github.com/apache/arrow/pull/35077
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
In the conda release verification we saw an error failure due to "build constraints exclude all files" in the `memory/mallocator` directory. This is easily fixed by adding a `doc.go` file with a package documentation and no build constraint on it to the directory. While here, to ensure everything is handled correctly, the `cgo` constraint was added to the default `mallocator` tagged files (and `!cgo` to the defaults) so that it's explicit rather than implicit (by virtue of importing mallocator which requires cgo).
This should, hopefully, also fix the other macos verification failure by ensuring the Time64 nanosecond parsing test doesn't just drop the extraneous 0.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are there any user-facing changes?
There shouldn't be.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35077: GH-35062: [Go][CI] Fix verification failures
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35077:
URL: https://github.com/apache/arrow/pull/35077#issuecomment-1505441079
* Closes: #35062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35077: GH-35062: [Go][CI] Fix verification failures
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35077:
URL: https://github.com/apache/arrow/pull/35077#issuecomment-1505562475
Revision: d11b5f43e6b3e94535a8723d08ac4edecd392209
Submitted crossbow builds: [ursacomputing/crossbow @ actions-37deb69887](https://github.com/ursacomputing/crossbow/branches/all?query=actions-37deb69887)
|Task|Status|
|----|------|
|verify-rc-source-go-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4680553027/jobs/8292040282)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35077: GH-35062: [Go][CI] Fix verification failures
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35077:
URL: https://github.com/apache/arrow/pull/35077#issuecomment-1509098223
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a48f99af134c429fb9fbb696ab5f35c3...6a8e3bdf7372444a840a6c8d3f646d2d/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35077: GH-35062: [Go][CI] Fix verification failures
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35077:
URL: https://github.com/apache/arrow/pull/35077#issuecomment-1505559378
@github-actions crossbow submit verify-rc-source-go-macos-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35077: GH-35062: [Go][CI] Fix verification failures
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35077:
URL: https://github.com/apache/arrow/pull/35077#issuecomment-1509097507
Benchmark runs are scheduled for baseline = 342b74e4192a69e849b67e36b054078c208fac91 and contender = 1912fb9a6a652001e17bfa08552309196d76b8ff. 1912fb9a6a652001e17bfa08552309196d76b8ff is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/23979d528fd8434b941211e8940a53d0...857147a210bc40c19c228bac6050cc5a/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/bad2da87103142a9b5aca591a245390f...e8ba6328386e4fc3bd3f5e475084133a/)
[Finished :arrow_down:1.79% :arrow_up:0.51%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a48f99af134c429fb9fbb696ab5f35c3...6a8e3bdf7372444a840a6c8d3f646d2d/)
[Finished :arrow_down:0.22% :arrow_up:0.49%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/231925ed81694a6ead6ecce12a3cd40b...cbb72b870c514fbb9f9103f93986ef8a/)
Buildkite builds:
[Finished] [`1912fb9a` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2697)
[Failed] [`1912fb9a` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2731)
[Finished] [`1912fb9a` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2695)
[Finished] [`1912fb9a` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2722)
[Finished] [`342b74e4` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2696)
[Failed] [`342b74e4` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2730)
[Finished] [`342b74e4` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2694)
[Finished] [`342b74e4` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2721)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35077: GH-35062: [Go][CI] Fix verification failures
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35077:
URL: https://github.com/apache/arrow/pull/35077#issuecomment-1505521133
@github-actions crossbow submit verify-rc-source-go-linux-conda-latest-amd64 verify-rc-source-go-macos-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35077: GH-35062: [Go][CI] Fix verification failures
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35077:
URL: https://github.com/apache/arrow/pull/35077#issuecomment-1505558446
Ugh, the issue with the macos-amd64 failure is that go1.20 changed some semantics in the `time` package that makes it no longer error on something that previously errored. So i'll just make an explicitly badly formatted value that should still error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35077: GH-35062: [Go][CI] Fix verification failures
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35077:
URL: https://github.com/apache/arrow/pull/35077#issuecomment-1505453086
Revision: e28442c51a16dd52a70a6331b56c9474aebdd84a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-54b9ffb319](https://github.com/ursacomputing/crossbow/branches/all?query=actions-54b9ffb319)
|Task|Status|
|----|------|
|verify-rc-source-go-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4679928984/jobs/8290613404)|
|verify-rc-source-go-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4679929208/jobs/8290613963)|
|verify-rc-source-go-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4679930108/jobs/8290616282)|
|verify-rc-source-go-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4679929734/jobs/8290615707)|
|verify-rc-source-go-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4679928649/jobs/8290612963)|
|verify-rc-source-go-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4679929554/jobs/8290614748)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35077: GH-35062: [Go][CI] Fix verification failures
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35077:
URL: https://github.com/apache/arrow/pull/35077#issuecomment-1505527388
Revision: 3a4a50e416de7e7cee2efa6b41a1edc9d67bcbf6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f76a8fe537](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f76a8fe537)
|Task|Status|
|----|------|
|verify-rc-source-go-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4680335341/jobs/8291548075)|
|verify-rc-source-go-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4680334766/jobs/8291547082)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser merged pull request #35077: GH-35062: [Go][CI] Fix verification failures
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser merged PR #35077:
URL: https://github.com/apache/arrow/pull/35077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35077: GH-35062: [Go][CI] Fix verification failures
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35077:
URL: https://github.com/apache/arrow/pull/35077#issuecomment-1505448421
@github-actions crossbow submit verify-rc-source-go-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org