You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/05/09 13:18:44 UTC

svn commit: r1859005 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java

Author: tilman
Date: Thu May  9 13:18:43 2019
New Revision: 1859005

URL: http://svn.apache.org/viewvc?rev=1859005&view=rev
Log:
PDFBOX-4539: don't construct new decoder each time, as suggested by Jonathan

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java?rev=1859005&r1=1859004&r2=1859005&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/BaseParser.java Thu May  9 13:18:43 2019
@@ -54,6 +54,8 @@ public abstract class BaseParser
 
     static final int MAX_LENGTH_LONG = Long.toString(Long.MAX_VALUE).length();
 
+    private final CharsetDecoder utf8Decoder = Charsets.UTF_8.newDecoder();
+
     /**
      * Log instance.
      */
@@ -780,10 +782,9 @@ public abstract class BaseParser
      */
     private boolean isValidUTF8(byte[] input)
     {
-        CharsetDecoder cs = Charsets.UTF_8.newDecoder();
         try
         {
-            cs.decode(ByteBuffer.wrap(input));
+            utf8Decoder.decode(ByteBuffer.wrap(input));
             return true;
         }
         catch (CharacterCodingException e)