You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "testikun (via GitHub)" <gi...@apache.org> on 2026/09/02 04:47:12 UTC
[PR] feat(desktop): support manual context compaction in Side Conversations [maka]
testikun opened a new pull request, #4532:
URL: https://github.com/apache/maka/pull/4532
## Summary
- Support the exact `/compact` command in idle, committed Side Conversations.
- Route compaction to the companion Session without sending `/compact` to the model or touching the source Session.
- Keep draft, quote, and attachment state intact when the fork is preparing, running, archived, unavailable, or the Host rejects the operation.
## Implementation
- Added the existing Session-scoped compaction operation to the Workbar Side Conversation port and Desktop adapter.
- Added command interception before steering/send and reused the existing compaction progress/terminal presentation semantics for the companion panel.
- Added retry-safe in-flight fencing, exact model/archive checks, and localized workspace-unavailable error handling.
## Tests
- `npm test` (full workspace suite)
- `npm --workspace @maka/desktop run typecheck`
- `npm --workspace @maka/desktop run check:architecture`
- Focused Desktop runtime tests: Side Conversation retry/dispatch tests, Workbar adapter tests, and existing main-conversation compaction tests (39 passing).
## Platform limitations
- This is a Desktop Workbar feature only; CLI/TUI `/compact` behavior is unchanged.
- It uses the existing Runtime Host context-compaction capability, so the operation remains subject to the selected model, workspace availability, and platform support already enforced by that capability.
Fixes #4521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(desktop): support manual context compaction in Side Conversations [maka]
Posted by "testikun (via GitHub)" <gi...@apache.org>.
testikun commented on PR #4532:
URL: https://github.com/apache/maka/pull/4532#issuecomment-5521132558
Thanks for the review. I rebased the PR onto the current `apache/main` (`0f4d20e31`) and addressed the compaction review findings on the new head `d2d6d58f6`.
- The compaction fence is released for matching terminal `abort` and non-recoverable `error` events.
- Terminal events are now fenced by the exact compaction `turnId`; if the Host terminal event arrives before the compact RPC response, it is buffered and settled only after the RPC confirms the same identity. An unrelated Turn completion can no longer release the lock or show a false compaction result.
- Added regression coverage for Host interruption, unrelated Turn completion, and lazy-fork preparation.
The focused Desktop Side Conversation suite passes 38/38, the Runtime Host projector suite passes 20/20, and the PR CI has been restarted on this rebased head. The remaining silent-refusal note is non-blocking and unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] feat(desktop): support manual context compaction in Side Conversations [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #4532:
URL: https://github.com/apache/maka/pull/4532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org