You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhztheplayer (via GitHub)" <gi...@apache.org> on 2024/11/25 04:03:47 UTC
Re: [PR] [GLUTEN-8010][CORE] Don't generate native metrics if transformer don't generate relNode [incubator-gluten]
zhztheplayer commented on code in PR #8011:
URL: https://github.com/apache/incubator-gluten/pull/8011#discussion_r1855745497
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ExpandExecTransformer.scala:
##########
@@ -112,13 +115,12 @@ case class ExpandExecTransformer(
override protected def doTransform(context: SubstraitContext): TransformContext = {
val childCtx = child.asInstanceOf[TransformSupport].transform(context)
- val operatorId = context.nextOperatorId(this.nodeName)
- if (projections == null || projections.isEmpty) {
+ if (metricsUpdater == MetricsUpdater.None) {
Review Comment:
Hi @zml1206
Can we create a new utility method, e.g, `isNoop` that can be called both by `doTransform` and `metricUpdater` in each operator? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org