You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/02/03 19:11:03 UTC

[kudu-CR](branch-1.18.x) KUDU-3563 Output tablet-level metrics in Prometheus

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22442


Change subject: KUDU-3563 Output tablet-level metrics in Prometheus
......................................................................

KUDU-3563 Output tablet-level metrics in Prometheus

Newline characters have been removed from tablet metric entity
descriptions because they produce invalid Prometheus format.

Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af
Reviewed-on: http://gerrit.cloudera.org:8080/22314
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 036c22968bc8725e191259865f793efa7097d30b)
---
M src/kudu/master/master-test.cc
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
7 files changed, 149 insertions(+), 28 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/22442/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af
Gerrit-Change-Number: 22442
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>

[kudu-CR](branch-1.18.x) KUDU-3563 Output tablet-level metrics in Prometheus

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22442 )

Change subject: KUDU-3563 Output tablet-level metrics in Prometheus
......................................................................

KUDU-3563 Output tablet-level metrics in Prometheus

Newline characters have been removed from tablet metric entity
descriptions because they produce invalid Prometheus format.

Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af
Reviewed-on: http://gerrit.cloudera.org:8080/22314
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 036c22968bc8725e191259865f793efa7097d30b)
Reviewed-on: http://gerrit.cloudera.org:8080/22442
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/master/master-test.cc
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
7 files changed, 149 insertions(+), 28 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Abhishek Chennaka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/22442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af
Gerrit-Change-Number: 22442
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>

[kudu-CR](branch-1.18.x) KUDU-3563 Output tablet-level metrics in Prometheus

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22442 )

Change subject: KUDU-3563 Output tablet-level metrics in Prometheus
......................................................................


Patch Set 1: Verified+1

unrelated Java test failures (TSAN): KUDU-3605


-- 
To view, visit http://gerrit.cloudera.org:8080/22442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af
Gerrit-Change-Number: 22442
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 00:31:41 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-3563 Output tablet-level metrics in Prometheus

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22442 )

Change subject: KUDU-3563 Output tablet-level metrics in Prometheus
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af
Gerrit-Change-Number: 22442
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 02:21:05 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-3563 Output tablet-level metrics in Prometheus

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22442 )

Change subject: KUDU-3563 Output tablet-level metrics in Prometheus
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1016/


-- 
To view, visit http://gerrit.cloudera.org:8080/22442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af
Gerrit-Change-Number: 22442
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2025 19:11:12 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-3563 Output tablet-level metrics in Prometheus

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22442 )

Change subject: KUDU-3563 Output tablet-level metrics in Prometheus
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1016/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af
Gerrit-Change-Number: 22442
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Feb 2025 20:17:24 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-3563 Output tablet-level metrics in Prometheus

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-3563 Output tablet-level metrics in Prometheus
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22442
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id033a1410966167d9bb24f6a44c584e73c17a4af
Gerrit-Change-Number: 22442
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>