You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "chrisdutz (via GitHub)" <gi...@apache.org> on 2023/08/18 07:16:57 UTC
[GitHub] [iotdb] chrisdutz opened a new pull request, #10907: Feature/streamlined grafana plugin profile
chrisdutz opened a new pull request, #10907:
URL: https://github.com/apache/iotdb/pull/10907
Till now the way the grafana plugin was added to the main project reactor was different to that of the other optional modules.
With this PR it matches that of the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #10907: Feature/streamlined grafana plugin profile
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on code in PR #10907:
URL: https://github.com/apache/iotdb/pull/10907#discussion_r1304072024
##########
distribution/pom.xml:
##########
@@ -125,24 +117,71 @@
<groupId>org.apache.iotdb</groupId>
<artifactId>library-udf</artifactId>
<version>${project.version}</version>
- <type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.iotdb</groupId>
<artifactId>spark-iotdb-connector_2.11</artifactId>
<version>${project.version}</version>
- <type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.iotdb</groupId>
<artifactId>spark-iotdb-connector_2.12</artifactId>
<version>${project.version}</version>
- <type>jar</type>
Review Comment:
Why do you remove the type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #10907: Feature/streamlined grafana plugin profile
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on PR #10907:
URL: https://github.com/apache/iotdb/pull/10907#issuecomment-1691191465
Should we also move this in the pom.xml file of distribution to a profile like we do for cpp client?
https://github.com/apache/iotdb/blob/e9fe0b1082dff04815e75a84b7778126af55d2eb/distribution/pom.xml#L112-L117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #10907: Feature/streamlined grafana plugin profile
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #10907:
URL: https://github.com/apache/iotdb/pull/10907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #10907: Feature/streamlined grafana plugin profile
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on PR #10907:
URL: https://github.com/apache/iotdb/pull/10907#issuecomment-1691093906
https://github.com/apache/iotdb/blob/e9fe0b1082dff04815e75a84b7778126af55d2eb/iotdb-connector/grafana-plugin/backend-compile.sh#L31-L33
To fix the error, you may need to modify these lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] chrisdutz commented on a diff in pull request #10907: Feature/streamlined grafana plugin profile
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on code in PR #10907:
URL: https://github.com/apache/iotdb/pull/10907#discussion_r1304163389
##########
distribution/pom.xml:
##########
@@ -125,24 +117,71 @@
<groupId>org.apache.iotdb</groupId>
<artifactId>library-udf</artifactId>
<version>${project.version}</version>
- <type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.iotdb</groupId>
<artifactId>spark-iotdb-connector_2.11</artifactId>
<version>${project.version}</version>
- <type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.iotdb</groupId>
<artifactId>spark-iotdb-connector_2.12</artifactId>
<version>${project.version}</version>
- <type>jar</type>
Review Comment:
Usually you don't specify it, if it's "jar" as that is the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] chrisdutz commented on pull request #10907: Feature/streamlined grafana plugin profile
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #10907:
URL: https://github.com/apache/iotdb/pull/10907#issuecomment-1691117528
Good catch ... but a bit odd as previously it was 1.13.0 ... so in that case it couldn't have worked with 1.14.0 in the script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org