You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2023/01/10 11:56:56 UTC

[GitHub] [orc] zhjwpku commented on pull request #1374: ORC-1355: [C++] change Writer::addUserMetadata's parameters to const reference

zhjwpku commented on PR #1374:
URL: https://github.com/apache/orc/pull/1374#issuecomment-1377150672

   > It would be better to do this as a single PR instead of one-by-one, @zhjwpku .
   
   I am reading the codebase file by file, not sure how many this kind of drawbacks will be ;(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org