You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/11/09 19:19:10 UTC
[jira] [Commented] (KAFKA-2782) Incorrect assertion in
KafkaBasedLogTest.testSendAndReadToEnd
[ https://issues.apache.org/jira/browse/KAFKA-2782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997050#comment-14997050 ]
ASF GitHub Bot commented on KAFKA-2782:
---------------------------------------
GitHub user ewencp opened a pull request:
https://github.com/apache/kafka/pull/463
KAFKA-2782: Fix KafkaBasedLogTest assertion and move it to the main test thread.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ewencp/kafka kafka-2782-fix-kafka-based-log-test-assertion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/463.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #463
----
commit 06b2ac5f5a374bd3d46926d865f951aabc16ccfb
Author: Ewen Cheslack-Postava <me...@ewencp.org>
Date: 2015-11-09T18:18:29Z
KAFKA-2782: Fix KafkaBasedLogTest assertion and move it to the main test thread.
----
> Incorrect assertion in KafkaBasedLogTest.testSendAndReadToEnd
> -------------------------------------------------------------
>
> Key: KAFKA-2782
> URL: https://issues.apache.org/jira/browse/KAFKA-2782
> Project: Kafka
> Issue Type: Bug
> Components: copycat
> Reporter: Ewen Cheslack-Postava
> Assignee: Ewen Cheslack-Postava
> Fix For: 0.9.0.0
>
>
> One of the assertions is incorrect. This is a bit hard to spot because that assertion is performed in a callback on a different thread, so if the assertion fails it can just kill the other thread and the test times out without a clear indication of what's going wrong. We can rearrange the assertion a bit to test the same thing but make the assertions execute in the main test thread.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)