[GitHub] [airflow] potiuk commented on a change in pull request #20276: Split redshift cluster and redshift sql

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #20276:
URL: https://github.com/apache/airflow/pull/20276#discussion_r768918924



##########
File path: airflow/providers/amazon/provider.yaml
##########
@@ -455,7 +461,8 @@ hook-class-names:  # deprecated - to be removed after providers add dependency o
   - airflow.providers.amazon.aws.hooks.s3.S3Hook
   - airflow.providers.amazon.aws.hooks.base_aws.AwsBaseHook
   - airflow.providers.amazon.aws.hooks.emr.EmrHook
-  - airflow.providers.amazon.aws.hooks.redshift.RedshiftSQLHook
+  - airflow.providers.amazon.aws.hooks.redshift_sql.RedshiftSQLHook
+  - airflow.providers.amazon.aws.hooks.redshift_cluster.RedshiftHook

Review comment:
       @dstandish  - this is the error: by declaring the RedshiftHook as "registered" connection it is registered with the same "connection type" as AwsBaseHook. It was not registered before, so you did not have this error.
   
   RedShiftHook does not provide it's own connection, it piggibacks on existing AwsBaseHook connection so you should not register it here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org