You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/15 07:10:34 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4384: systemvm: FIX haproxy is not reloaded but restarted in VR

sureshanaparti commented on a change in pull request #4384:
URL: https://github.com/apache/cloudstack/pull/4384#discussion_r505243494



##########
File path: systemvm/debian/opt/cloud/bin/cs/CsLoadBalancer.py
##########
@@ -46,7 +46,7 @@ def process(self):
             CsHelper.copy(HAPROXY_CONF_T, HAPROXY_CONF_P)
 
             proc = CsProcess(['/run/haproxy.pid'])
-            if not proc.find():
+            if proc.grep("/usr/sbin/haproxy") == -1:

Review comment:
       @ustcweizhou this is the same fix done in the PR: https://github.com/apache/cloudstack/pull/4386, changes in "_CsRedundant.py_" for keepalived process. As I've commented in that PR, on a broader view, other processes might have similar issue. can this be fixed in CsProcess.py find() ? else at some point, we can end up replacing all _proc.find()_ with _proc.grep()_.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org