[jira] [Commented] (HDFS-16723) Replace incorrect SafeModeException with StandbyException in RouterRpcServer.class

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-16723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576409#comment-17576409 ] 

ASF GitHub Bot commented on HDFS-16723:
---------------------------------------

ZanderXu opened a new pull request, #4716:
URL: https://github.com/apache/hadoop/pull/4716

   ### Description of PR
   Incorrect code as below:
   ```
   /**
    * ...
    * @throws SafeModeException If the Router is in safe mode and cannot serve
    *                           client requests.
    */
   void checkOperation(OperationCategory op)
       throws StandbyException {
     ...
   }
   ```
   I feel that we should fix the incorrect  SafeModeException and use StandbyException instead of it.
   




> Replace incorrect SafeModeException with StandbyException in RouterRpcServer.class
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-16723
>                 URL: https://issues.apache.org/jira/browse/HDFS-16723
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: ZanderXu
>            Assignee: ZanderXu
>            Priority: Major
>
> Incorrect code as below:
> {code:java}
> /**
>  * ...
>  * @throws SafeModeException If the Router is in safe mode and cannot serve
>  *                           client requests.
>  */
> void checkOperation(OperationCategory op)
>     throws StandbyException {
>   ...
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org