You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/20 00:12:52 UTC

[GitHub] [airflow] SamWheating edited a comment on issue #11901: DAGs remain in the UI after renaming the dag_id in the same python file

SamWheating edited a comment on issue #11901:
URL: https://github.com/apache/airflow/issues/11901#issuecomment-882946410


   But even then, as @leonsmith identified, a renamed DAG will be marked as active again on the next pass:
   https://github.com/apache/airflow/blob/3234527284ce01db67ba22c544f71ddaf28fa27e/airflow/models/dag.py#L2476-L2497
   
   Is the assumption that 1 file corresponds to 1 DAG still valid? That would contradict patterns such as the [DAG factory](https://github.com/ajbosco/dag-factory) which load many DAGs from a single `.py` file. 
   
   Anyways, maybe we should be leaving DAGs as deactivated if they haven't been parsed in a given interval? I'm happy to submit a fix for this and I'll have some time in the next few days, however I'd like some guidance from the maintainers on what is the intended behaviour / what are the supported patterns before I start 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org