You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by shawnfeldman <gi...@git.apache.org> on 2015/01/28 03:33:30 UTC
[GitHub] incubator-usergrid pull request: fix authentication workflow
GitHub user shawnfeldman opened a pull request:
https://github.com/apache/incubator-usergrid/pull/156
fix authentication workflow
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-usergrid dotnet-sample-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-usergrid/pull/156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #156
----
commit bfdacb34ebdf918fcf92307c14808cadd5bdd7fd
Author: Shawn Feldman <sf...@apache.org>
Date: 2015-01-28T02:31:58Z
fix authentication workflow
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: fix authentication workflow
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-usergrid/pull/156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: fix authentication workflow
Posted by r3b <gi...@git.apache.org>.
Github user r3b commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/156#discussion_r23695517
--- Diff: sdks/dotnet/samples/notifications/Usergrid.Notifications/Client/PushClient.cs ---
@@ -114,7 +116,7 @@ public PushClient(IUsergridHttpClient usergrid, string notifier)
private async Task<JToken> GetDevice(Guid deviceId)
{
- var jsonResponse = await usergrid.SendAsync(HttpMethod.Get, "devices/" + deviceId, null);
+ var jsonResponse = await usergrid.SendAsync(HttpMethod.Get, "users/"+userId+"/devices/" + deviceId, null);
--- End diff --
why not use String.Format here? It's not consistent with previous methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---