You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/01/30 02:11:47 UTC

[GitHub] spark pull request #20427: [SPARK-23260][SPARK-23262][SQL] several data sour...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20427#discussion_r164623731
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/SessionConfigSupport.java ---
    @@ -25,7 +25,7 @@
      * session.
      */
     @InterfaceStability.Evolving
    -public interface SessionConfigSupport {
    +public interface SessionConfigSupport extends DataSourceV2 {
    --- End diff --
    
    Created https://issues.apache.org/jira/browse/SPARK-23262 .
    
    I'd like to keep the changes in this PR, as it's just several lines. It's not ideal but we are rushing for the 2.3 release, I wanna speed this up a little, what do you think?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org