You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "MartijnVisser (via GitHub)" <gi...@apache.org> on 2023/04/03 12:59:11 UTC

[GitHub] [flink-connector-rabbitmq] MartijnVisser commented on a diff in pull request #7: [FLINK-31701][Connector/RabbitMQ] Fix misc nightly build issues

MartijnVisser commented on code in PR #7:
URL: https://github.com/apache/flink-connector-rabbitmq/pull/7#discussion_r1155929832


##########
.github/workflows/weekly.yml:
##########
@@ -20,13 +20,14 @@ name: Nightly
 on:
   schedule:
     - cron: "0 0 * * 0"
+  workflow_dispatch:
 jobs:
   compile_and_test:
     if: github.repository_owner == 'apache'
     strategy:
       matrix:
-        flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT]
+        flink: [1.17-SNAPSHOT, 1.18-SNAPSHOT]

Review Comment:
   Then we'll know for sure that the tests will be failing, since the Archunit upgrade in 1.17 is a breaking change compared to Flink 1.16. Then we need to consider also disabling the Archunit tests in the nightly builds (which might not be a bad idea)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org