You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/27 16:22:21 UTC
[GitHub] [flink] WencongLiu opened a new pull request, #19596: [FLINK-25970][core] Add type of original exception to the detailMessage of SerializedThrowable.
WencongLiu opened a new pull request, #19596:
URL: https://github.com/apache/flink/pull/19596
SerializedThrowable will return itself as a stand in if an exception occurs when calling deserializeError(ClassLoader classloader). When this happens, the call stack printed by logger will not contain the class name of original exception.
Therefore, class name information is added to the detailMessage of SerializedThrowable in this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #19596: [FLINK-25970][core] Add type of original exception to the detailMessage of SerializedThrowable.
Posted by GitBox <gi...@apache.org>.
xintongsong commented on PR #19596:
URL: https://github.com/apache/flink/pull/19596#issuecomment-1112878445
Hi @WencongLiu,
I think the code changes show that you've understood the issue correctly. I have mainly two comments:
1. I'm not sure about the `className(message)` format. Notice that the original message could be long and contain line breaks. Maybe `className: message` is better.
2. CI report shows some test failures. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19596: [FLINK-25970][core] Add type of original exception to the detailMessage of SerializedThrowable.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19596:
URL: https://github.com/apache/flink/pull/19596#issuecomment-1111207343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "939dc295747eee605dab641150cf14ea1e3fe908",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "939dc295747eee605dab641150cf14ea1e3fe908",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 939dc295747eee605dab641150cf14ea1e3fe908 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] WencongLiu closed pull request #19596: [FLINK-25970][core] Add type of original exception to the detailMessage of SerializedThrowable.
Posted by GitBox <gi...@apache.org>.
WencongLiu closed pull request #19596: [FLINK-25970][core] Add type of original exception to the detailMessage of SerializedThrowable.
URL: https://github.com/apache/flink/pull/19596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #19596: [FLINK-25970][core] Add type of original exception to the detailMessage of SerializedThrowable.
Posted by GitBox <gi...@apache.org>.
xintongsong commented on PR #19596:
URL: https://github.com/apache/flink/pull/19596#issuecomment-1112879304
And you should not open a PR to `release-1.14.3-rc1`. Normally PRs should be opened to the `master` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org