[jira] [Commented] (HIVE-13533) Remove AST dump

["Sergey Shelukhin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-13533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866977#comment-15866977 ] 

Sergey Shelukhin commented on HIVE-13533:
-----------------------------------------

AST dump is useful in some cases... perhaps there should be a separate explain that would output it?

> Remove AST dump
> ---------------
>
>                 Key: HIVE-13533
>                 URL: https://issues.apache.org/jira/browse/HIVE-13533
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 2.1.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>             Fix For: 2.1.0
>
>         Attachments: HIVE-13533.patch, HIVE-13533.patch
>
>
> For very large queries, dumping the AST can lead to OOM errors. Currently there are two places where we dump the AST:
> - CalcitePlanner if we are running in DEBUG mode (line 300).
> - ExplainTask if we use extended explain (line 179).
> I guess the original reason to add the dump was to check whether the AST conversion from CBO was working properly, but I think we are past that stage now.
> We will remove the logic to dump the AST in explain extended. For debug mode in CalcitePlanner, we will lower the level to LOG.TRACE.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)