[jira] [Commented] (SLING-5371) JcrInstaller should not listen on / for moves

["Marc Pfaff (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126992#comment-15126992 ] 

Marc Pfaff commented on SLING-5371:
-----------------------------------

Hi [~bdelacretaz]. Sorry for the late reply. I think I figured what's wrong with the RootFolderMoveListenerTest.testMove() test. The RootFolderMoveListener is registered with the noLocal property set to true. But for the test class we use the same session for registering the RootFolderMoveListener and for performing the content move. Because noLocal is set to true no observations are delivered to the RootFolderMoveListener. 

I refactored the test a little bit to use 2 sessions, one for registering the listener and one to perform the move, and now the test is passing fine for me. Please see patch SLING_5371_fixing_testclass.patch.  

> JcrInstaller should not listen on / for moves
> ---------------------------------------------
>
>                 Key: SLING-5371
>                 URL: https://issues.apache.org/jira/browse/SLING-5371
>             Project: Sling
>          Issue Type: Improvement
>          Components: Installer
>            Reporter: Marc Pfaff
>            Assignee: Bertrand Delacretaz
>         Attachments: SLING_5371.patch, SLING_5371_fixing_testclass.patch, SLING_5371_jackrabbit.patch, SLING_5371_jcr_only.patch
>
>
> The JcrInstaller is currently registering a JCR listener for move events on the root node with setting the 'deep' property to true. If it comes to processing the underlaying Oak observation queue, this combination is very inefficient, as it does not allow Oak to filter changes by path. 
> AFAIU this move listener is covering the use case where an installer artifact is moved from/to an installer root folder. I therefore wanted to propose to register the move listener on the configured root folders only.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)