You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/02/06 17:35:51 UTC
[GitHub] [activemq-artemis] jbertram opened a new pull request #2973:
NO-JIRA clarify & verify web socket support for MQTT
jbertram opened a new pull request #2973: NO-JIRA clarify & verify web socket support for MQTT
URL: https://github.com/apache/activemq-artemis/pull/2973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] tabish121 commented on a change in pull request
#2973: NO-JIRA clarify & verify web socket support for MQTT
Posted by GitBox <gi...@apache.org>.
tabish121 commented on a change in pull request #2973: NO-JIRA clarify & verify web socket support for MQTT
URL: https://github.com/apache/activemq-artemis/pull/2973#discussion_r375982380
##########
File path: docs/user-manual/en/amqp.md
##########
@@ -155,4 +155,20 @@ This contains a real example for configuring amqpIdleTimeout:
```xml
<acceptor name="amqp">tcp://0.0.0.0:5672?amqpIdleTimeout=0;tcpSendBufferSize=1048576;tcpReceiveBufferSize=1048576;protocols=AMQP;useEpoll=true;amqpCredits=1000;amqpMinCredits=300;directDeliver=false;batchDelay=10</acceptor>
-```
\ No newline at end of file
+```
+
+## Web Sockets
+
+Apache ActiveMQ Artemis also supports AMQP over [Web
+Sockets](https://html.spec.whatwg.org/multipage/web-sockets.html). Modern web
+browsers which support Web Sockets can send and receive AMQP messages.
+
+MQTT over Web Sockets is supported via a normal AMQP acceptor:
Review comment:
Think you mean AMQP here, MQTT over the AMQP accepter seems wrong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on a change in pull request
#2973: NO-JIRA clarify & verify web socket support for MQTT
Posted by GitBox <gi...@apache.org>.
jbertram commented on a change in pull request #2973: NO-JIRA clarify & verify web socket support for MQTT
URL: https://github.com/apache/activemq-artemis/pull/2973#discussion_r375982844
##########
File path: docs/user-manual/en/amqp.md
##########
@@ -155,4 +155,20 @@ This contains a real example for configuring amqpIdleTimeout:
```xml
<acceptor name="amqp">tcp://0.0.0.0:5672?amqpIdleTimeout=0;tcpSendBufferSize=1048576;tcpReceiveBufferSize=1048576;protocols=AMQP;useEpoll=true;amqpCredits=1000;amqpMinCredits=300;directDeliver=false;batchDelay=10</acceptor>
-```
\ No newline at end of file
+```
+
+## Web Sockets
+
+Apache ActiveMQ Artemis also supports AMQP over [Web
+Sockets](https://html.spec.whatwg.org/multipage/web-sockets.html). Modern web
+browsers which support Web Sockets can send and receive AMQP messages.
+
+MQTT over Web Sockets is supported via a normal AMQP acceptor:
Review comment:
Fixed. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #2973: NO-JIRA
clarify & verify web socket support for MQTT
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2973: NO-JIRA clarify & verify web socket support for MQTT
URL: https://github.com/apache/activemq-artemis/pull/2973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services