[GitHub] [nifi] MikeThomsen commented on a change in pull request #4309: NIFI-7497 Adding support for AWS Credentials Assume Role to be able t…

[GitBox <gi...@apache.org>]

MikeThomsen commented on a change in pull request #4309:
URL: https://github.com/apache/nifi/pull/4309#discussion_r451174955



##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/CredentialPropertyDescriptors.java
##########
@@ -177,6 +177,16 @@
             .required(false)
             .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
             .sensitive(false)
-            .description("Proxy pot for cross-account access, if needed within your environment. This will configure a proxy to request for temporary access keys into another AWS account")
+            .description("Proxy port for cross-account access, if needed within your environment. This will configure a proxy to request for temporary access keys into another AWS account")
+            .build();
+    
+    public static final PropertyDescriptor ASSUME_ROLE_STS_ENDPOINT = new PropertyDescriptor.Builder()
+            .name("assume-role-sts-endpoint")
+            .displayName("Assume Role STS Endpoint")
+            .expressionLanguageSupported(ExpressionLanguageScope.NONE)
+            .required(false)
+            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+            .sensitive(false)
+            .description("STS Endpoint override for cross-account access, if needed within your environment.")

Review comment:
       @pvillard31 If that change is the only thing blocking this, I can make it and merge. Let me know if you're +1 on that. We have a use case that really needs this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org