You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Gordon Sim (Commented) (JIRA)" <ji...@apache.org> on 2011/11/04 18:01:51 UTC
[jira] [Commented] (QPID-3585) Alternative exchange Python test
(test_add_alternate_to_exchange) not in line with 0-10 spec
[ https://issues.apache.org/jira/browse/QPID-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144162#comment-13144162 ]
Gordon Sim commented on QPID-3585:
----------------------------------
I'd argue that the specification means the exception should not be thrown if the declare has an empty alternate-exchange field, but that if the declare specifies an alternate exchange that should match any pre-existing setting. The spirit of the rule is surely to ensure that if you care about the alternate-exchange - indicated by including that in your declare - then it should be validated. If the alternate exchange is not as expected, even if because there is no alternate exchange, I think that *should* be an error.
At the very least we should change the test to have an alternate-exchange and redeclare it with a different one. The change in this patch seems to result in a rather pointless test.
> Alternative exchange Python test (test_add_alternate_to_exchange) not in line with 0-10 spec
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3585
> URL: https://issues.apache.org/jira/browse/QPID-3585
> Project: Qpid
> Issue Type: Bug
> Components: Python Test Suite
> Affects Versions: 0.12
> Reporter: Andrew MacBean
> Assignee: Robbie Gemmell
> Priority: Trivial
> Attachments: 0001-QPID-3585-Alternative-exchange-Python-test-test_add_.patch
>
>
> The logic of the following 0-10 broker test for Alternate Exchange is not in line with the spec.
> qpid_tests.broker_0_10.alternate_exchange.AlternateExchangeTests.test_add_alternate_to_exchange
> This tests that an exception is thrown when an alternate exchange is specified for an already existing exchange. The spec says that an exception should be thrown if "the alternate-exchange is not empty and if the exchange already exists with a different alternate-exchange", in this case it is empty and so should not throw an excpetion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org