You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/21 02:33:34 UTC
[GitHub] [kafka] vvcephei opened a new pull request #10369: KAFKA-12514: Fix NPE in SubscriptionState
vvcephei opened a new pull request #10369:
URL: https://github.com/apache/kafka/pull/10369
Return null for partitionLag if there is no current position.
This was the desired semantics, the lack of the check was an
oversight.
Patches: KIP-695
Patches: a92b986c855592d630fbabf49d1e9a160ad5b230
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10369: KAFKA-12514: Fix NPE in SubscriptionState
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #10369:
URL: https://github.com/apache/kafka/pull/10369#issuecomment-803501841
Hey @guozhangwang or maybe @ableegoldman , do you think you could take a quick look at this?
In the javadoc for KIP-695's `currentLag` API, I even stated that it would return an "empty" OptionalLong if there is no position, but I neglected to check for that condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10369: KAFKA-12514: Fix NPE in SubscriptionState
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #10369:
URL: https://github.com/apache/kafka/pull/10369#issuecomment-803507718
Thanks, @wcarlson5 and @ableegoldman !
Good point; I added a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei merged pull request #10369: KAFKA-12514: Fix NPE in SubscriptionState
Posted by GitBox <gi...@apache.org>.
vvcephei merged pull request #10369:
URL: https://github.com/apache/kafka/pull/10369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #10369: KAFKA-12514: Fix NPE in SubscriptionState
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #10369:
URL: https://github.com/apache/kafka/pull/10369#issuecomment-803713664
Looks like only a couple of unrelated test failures, so i went ahead with the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #10369: KAFKA-12514: Fix NPE in SubscriptionState
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on pull request #10369:
URL: https://github.com/apache/kafka/pull/10369#issuecomment-803517708
@lct45 you might need to pick this to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org