[GitHub] [tvm] lhutton1 commented on a diff in pull request #11091: [AOT] Enable A-Normal Form in the AOT executor

[GitBox <gi...@apache.org>]

lhutton1 commented on code in PR #11091:
URL: https://github.com/apache/tvm/pull/11091#discussion_r863992324


##########
src/relay/backend/aot_executor_codegen.cc:
##########
@@ -126,7 +126,14 @@ class AOTOnDemandAllocator : public transform::DeviceAwareExprVisitor {
     for (const auto& param : func_node->params) {
       CreateStorage(param.get());
     }
-    GetStorage(func_node->body);
+    StorageInfo si = GetStorage(func_node->body);
+
+    // If the final expr could not be found it means it was let bound,

Review Comment:
   Thanks for the suggestion @mbs-octoml, the changes now look much cleaner!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org