You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2020/01/17 10:11:33 UTC

[camel] branch master updated (644cad9 -> 424f9d3)

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git.


    from 644cad9  Polished
     new d1a866d  CAMEL-14534: camel-core - Optimize reactive engine to use Deque instead of LinkedList which is faster and dont cause soo much object allocations.
     new 424f9d3  CAMEL-14534: camel-core - Optimize

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../apache/camel/impl/engine/DefaultReactiveExecutor.java    | 12 ++++++------
 .../camel/processor/errorhandler/RedeliveryErrorHandler.java |  2 --
 2 files changed, 6 insertions(+), 8 deletions(-)


[camel] 01/02: CAMEL-14534: camel-core - Optimize reactive engine to use Deque instead of LinkedList which is faster and dont cause soo much object allocations.

Posted by da...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit d1a866d0c8fe38c38b722df02c6fac8ba23d28e8
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Fri Jan 17 11:00:38 2020 +0100

    CAMEL-14534: camel-core - Optimize reactive engine to use Deque instead of LinkedList which is faster and dont cause soo much object allocations.
---
 .../apache/camel/impl/engine/DefaultReactiveExecutor.java    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultReactiveExecutor.java b/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultReactiveExecutor.java
index b12b8f4..d3467b1 100644
--- a/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultReactiveExecutor.java
+++ b/core/camel-base/src/main/java/org/apache/camel/impl/engine/DefaultReactiveExecutor.java
@@ -16,12 +16,12 @@
  */
 package org.apache.camel.impl.engine;
 
-import java.util.LinkedList;
+import java.util.ArrayDeque;
+import java.util.Deque;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.function.Supplier;
 
-import org.apache.camel.AsyncCallback;
 import org.apache.camel.StaticService;
 import org.apache.camel.api.management.ManagedAttribute;
 import org.apache.camel.api.management.ManagedResource;
@@ -136,8 +136,8 @@ public class DefaultReactiveExecutor extends ServiceSupport implements ReactiveE
     private static class Worker {
 
         private final DefaultReactiveExecutor executor;
-        private volatile LinkedList<Runnable> queue = new LinkedList<>();
-        private volatile LinkedList<LinkedList<Runnable>> back;
+        private volatile Deque<Runnable> queue = new ArrayDeque<>();
+        private volatile Deque<Deque<Runnable>> back;
         private volatile boolean running;
 
         public Worker(DefaultReactiveExecutor executor) {
@@ -151,10 +151,10 @@ public class DefaultReactiveExecutor extends ServiceSupport implements ReactiveE
             if (main) {
                 if (!queue.isEmpty()) {
                     if (back == null) {
-                        back = new LinkedList<>();
+                        back = new ArrayDeque<>();
                     }
                     back.push(queue);
-                    queue = new LinkedList<>();
+                    queue = new ArrayDeque<>();
                 }
             }
             if (first) {


[camel] 02/02: CAMEL-14534: camel-core - Optimize

Posted by da...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 424f9d3bae10683e98da8e3e042ca6a49ba1a565
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Fri Jan 17 11:04:02 2020 +0100

    CAMEL-14534: camel-core - Optimize
---
 .../org/apache/camel/processor/errorhandler/RedeliveryErrorHandler.java | 2 --
 1 file changed, 2 deletions(-)

diff --git a/core/camel-base/src/main/java/org/apache/camel/processor/errorhandler/RedeliveryErrorHandler.java b/core/camel-base/src/main/java/org/apache/camel/processor/errorhandler/RedeliveryErrorHandler.java
index 5e3cba3..7f5abc6 100644
--- a/core/camel-base/src/main/java/org/apache/camel/processor/errorhandler/RedeliveryErrorHandler.java
+++ b/core/camel-base/src/main/java/org/apache/camel/processor/errorhandler/RedeliveryErrorHandler.java
@@ -350,11 +350,9 @@ public abstract class RedeliveryErrorHandler extends ErrorHandlerSupport impleme
         Exchange original;
         Exchange exchange;
         AsyncCallback callback;
-        boolean sync = true;
         int redeliveryCounter;
         long redeliveryDelay;
         Predicate retryWhilePredicate;
-        boolean redeliverFromSync;
 
         // default behavior which can be overloaded on a per exception basis
         RedeliveryPolicy currentRedeliveryPolicy;