You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2015/09/29 22:52:37 UTC

Review Request 38861: FALCON-1499 Lifecycle bug fixes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38861/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-1499
    https://issues.apache.org/jira/browse/FALCON-1499


Repository: falcon-git


Description
-------

Two issues:
1) Some properties were missing from startup.properties
2) NullPointerException when queueName and priority are not specified in retentionStage.
Originally reported by Pragya Mittal.


Diffs
-----

  common/src/main/resources/startup.properties 3383129 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java 4601070 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java 0a87213 
  src/conf/startup.properties 8e4ce97 

Diff: https://reviews.apache.org/r/38861/diff/


Testing
-------


Thanks,

Ajay Yadava

Re: Review Request 38861: FALCON-1499 Lifecycle bug fixes

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38861/#review101195
-----------------------------------------------------------

Ship it!


Ship It!

- Srikanth Sundarrajan


On Sept. 30, 2015, 8:07 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38861/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 8:07 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1499
>     https://issues.apache.org/jira/browse/FALCON-1499
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Two issues:
> 1) Some properties were missing from startup.properties
> 2) NullPointerException when queueName and priority are not specified in retentionStage.
> Originally reported by Pragya Mittal.
> 
> 
> Diffs
> -----
> 
>   common/src/main/resources/startup.properties 3383129 
>   lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java 4601070 
>   lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java 0a87213 
>   src/conf/startup.properties 8e4ce97 
> 
> Diff: https://reviews.apache.org/r/38861/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 38861: FALCON-1499 Lifecycle bug fixes

Posted by sandeep samudrala <sa...@gmail.com>.

> On Sept. 30, 2015, 12:31 p.m., PRAGYA MITTAL wrote:
> > lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java, line 86
> > <https://reviews.apache.org/r/38861/diff/2/?file=1087689#file1087689line86>
> >
> >     Currently retention uses the feed level properties if set.IMO, for lifecycle also priority and queue should honour the feedLevelProperty if set in feed.

Its honoring as feed level properties


- sandeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38861/#review101110
-----------------------------------------------------------


On Sept. 30, 2015, 8:07 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38861/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 8:07 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1499
>     https://issues.apache.org/jira/browse/FALCON-1499
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Two issues:
> 1) Some properties were missing from startup.properties
> 2) NullPointerException when queueName and priority are not specified in retentionStage.
> Originally reported by Pragya Mittal.
> 
> 
> Diffs
> -----
> 
>   common/src/main/resources/startup.properties 3383129 
>   lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java 4601070 
>   lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java 0a87213 
>   src/conf/startup.properties 8e4ce97 
> 
> Diff: https://reviews.apache.org/r/38861/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 38861: FALCON-1499 Lifecycle bug fixes

Posted by sandeep samudrala <sa...@gmail.com>.

- sandeep


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38861/#review101110
-----------------------------------------------------------


On Sept. 30, 2015, 8:07 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38861/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 8:07 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1499
>     https://issues.apache.org/jira/browse/FALCON-1499
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Two issues:
> 1) Some properties were missing from startup.properties
> 2) NullPointerException when queueName and priority are not specified in retentionStage.
> Originally reported by Pragya Mittal.
> 
> 
> Diffs
> -----
> 
>   common/src/main/resources/startup.properties 3383129 
>   lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java 4601070 
>   lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java 0a87213 
>   src/conf/startup.properties 8e4ce97 
> 
> Diff: https://reviews.apache.org/r/38861/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 38861: FALCON-1499 Lifecycle bug fixes

Posted by PRAGYA MITTAL <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38861/#review101110
-----------------------------------------------------------



lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java (line 86)
<https://reviews.apache.org/r/38861/#comment158437>

    Currently retention uses the feed level properties if set.IMO, for lifecycle also priority and queue should honour the feedLevelProperty if set in feed.


- PRAGYA MITTAL


On Sept. 30, 2015, 8:07 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38861/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 8:07 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1499
>     https://issues.apache.org/jira/browse/FALCON-1499
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Two issues:
> 1) Some properties were missing from startup.properties
> 2) NullPointerException when queueName and priority are not specified in retentionStage.
> Originally reported by Pragya Mittal.
> 
> 
> Diffs
> -----
> 
>   common/src/main/resources/startup.properties 3383129 
>   lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java 4601070 
>   lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java 0a87213 
>   src/conf/startup.properties 8e4ce97 
> 
> Diff: https://reviews.apache.org/r/38861/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 38861: FALCON-1499 Lifecycle bug fixes

Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38861/#review101111
-----------------------------------------------------------

Ship it!


Ship It!

- sandeep samudrala


On Sept. 30, 2015, 8:07 a.m., Ajay Yadava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38861/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 8:07 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1499
>     https://issues.apache.org/jira/browse/FALCON-1499
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Two issues:
> 1) Some properties were missing from startup.properties
> 2) NullPointerException when queueName and priority are not specified in retentionStage.
> Originally reported by Pragya Mittal.
> 
> 
> Diffs
> -----
> 
>   common/src/main/resources/startup.properties 3383129 
>   lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java 4601070 
>   lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java 0a87213 
>   src/conf/startup.properties 8e4ce97 
> 
> Diff: https://reviews.apache.org/r/38861/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ajay Yadava
> 
>

Re: Review Request 38861: FALCON-1499 Lifecycle bug fixes

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38861/
-----------------------------------------------------------

(Updated Sept. 30, 2015, 8:07 a.m.)


Review request for Falcon.


Bugs: FALCON-1499
    https://issues.apache.org/jira/browse/FALCON-1499


Repository: falcon-git


Description
-------

Two issues:
1) Some properties were missing from startup.properties
2) NullPointerException when queueName and priority are not specified in retentionStage.
Originally reported by Pragya Mittal.


Diffs (updated)
-----

  common/src/main/resources/startup.properties 3383129 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedCoordinatorBuilder.java 4601070 
  lifecycle/src/main/java/org/apache/falcon/lifecycle/engine/oozie/retention/AgeBasedWorkflowBuilder.java 0a87213 
  src/conf/startup.properties 8e4ce97 

Diff: https://reviews.apache.org/r/38861/diff/


Testing
-------


Thanks,

Ajay Yadava