You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/11/03 13:29:00 UTC

[jira] [Work logged] (BEAM-11144) TriggerStateMachine.prefetchOnElement and other prefetch methods use incorrect state for subtriggers

     [ https://issues.apache.org/jira/browse/BEAM-11144?focusedWorklogId=506636&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-506636 ]

ASF GitHub Bot logged work on BEAM-11144:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Nov/20 13:28
            Start Date: 03/Nov/20 13:28
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on pull request #13221:
URL: https://github.com/apache/beam/pull/13221#issuecomment-720720140


   Oh, yes, the whole module is OK to change. It is just for core runners (those that are in this repo and can be adjusted if needed).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 506636)
    Time Spent: 0.5h  (was: 20m)

> TriggerStateMachine.prefetchOnElement and other prefetch methods use incorrect state for subtriggers
> ----------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-11144
>                 URL: https://issues.apache.org/jira/browse/BEAM-11144
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Sam Whittle
>            Assignee: Sam Whittle
>            Priority: P2
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> prefetchOnElement takes a single StateAccessor corresponding to the root trigger.  It uses that state accessor to perform prefetches for the subtrigger state. However that will use the root trigger namespace for the tags in the subtriggers.  This makes prefetching ineffective, introducing possibly an additional round-trip once the data is actually read.
> https://github.com/apache/beam/blob/68d6c8e6243b1d8f392840273f886276e2a8baff/runners/core-java/src/main/java/org/apache/beam/runners/core/triggers/TriggerStateMachine.java#L296



--
This message was sent by Atlassian Jira
(v8.3.4#803005)