[GitHub] [airflow] potiuk commented on a diff in pull request #22327: Rewrite Selective Check in Python

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #22327:
URL: https://github.com/apache/airflow/pull/22327#discussion_r841269891


##########
dev/breeze/src/airflow_ci/sc_get_changed_files.py:
##########
@@ -0,0 +1,71 @@
+#!/usr/bin/env python3

Review Comment:
   I think we do not need a separate command for "get_changed_files". This is (at least for now) not very useful. But it should be a "utility" function. something that other real "commands" can use.
   
   I think our commands should be centered around the "functionality" we need from selective checks.
   
   Just to explain what I envision:
   
   ```
   airflow-selective-checks  build-image
   ```
   
   This should produce one output:
   
   ```
   ::set-output name=image-build::true
   ```
   or
   ```
   ::set-output name=image-build::false
   ```
   
   Depends on the set of changed files.
   
   
   Similarly we should have other commands:
   
   ```
   airflow-selective-checks  matrix-strategy
   ```
   
   This one should produce all the "matrix" components (also as ga-output):
   - python, backend, kubernetes etc. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org