You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mengxr <gi...@git.apache.org> on 2014/07/10 03:31:11 UTC

[GitHub] spark pull request: SPARK-2281 [MLlib] Simplify the duplicate code...

Github user mengxr commented on the pull request:

    https://github.com/apache/spark/pull/1215#issuecomment-48555878
  
    @dbtsai As we discussed offline, this is an incompatible change, and it doesn't seem to be necessary. You can throw an exception in your implementation if you don't want to implement the old API. Do you mind closing this and the associated JIRA?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---