You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by da...@apache.org on 2023/03/13 14:01:25 UTC
[causeway] 02/02: CAUSEWAY-3373: polishes
This is an automated email from the ASF dual-hosted git repository.
danhaywood pushed a commit to branch CAUSEWAY-3373
in repository https://gitbox.apache.org/repos/asf/causeway.git
commit 8c3c1c5b06e1fd7654151b885f13ddffe72f460e
Author: danhaywood <da...@haywood-associates.co.uk>
AuthorDate: Mon Mar 13 14:01:07 2023 +0000
CAUSEWAY-3373: polishes
---
.../services/publishing/log/PageRenderLogger.java | 17 +++++++++++++----
build.sh | 1 +
valuetypes/asciidoc/persistence-jpa/pom.xml | 2 +-
valuetypes/markdown/persistence-jpa/pom.xml | 2 +-
valuetypes/vega/persistence-jpa/pom.xml | 2 +-
5 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/api/applib/src/main/java/org/apache/causeway/applib/services/publishing/log/PageRenderLogger.java b/api/applib/src/main/java/org/apache/causeway/applib/services/publishing/log/PageRenderLogger.java
index aa14bb29bf..304d600807 100644
--- a/api/applib/src/main/java/org/apache/causeway/applib/services/publishing/log/PageRenderLogger.java
+++ b/api/applib/src/main/java/org/apache/causeway/applib/services/publishing/log/PageRenderLogger.java
@@ -22,6 +22,7 @@ import lombok.extern.log4j.Log4j2;
import lombok.val;
import java.util.List;
+import java.util.concurrent.atomic.AtomicBoolean;
import java.util.function.Supplier;
import javax.annotation.Priority;
@@ -57,19 +58,27 @@ public class PageRenderLogger implements PageRenderSubscriber {
@Override
public void onRenderedDomainObject(Bookmark bookmark) {
- log.debug("rendered object: {}", bookmark.stringify());
+ log.debug("rendered object: [ \"{}\" ]", bookmark.stringify());
}
@Override
public void onRenderedCollection(Supplier<List<Bookmark>> bookmarkSupplier) {
val buf = new StringBuffer();
- bookmarkSupplier.get().forEach(x -> buf.append(x.stringify()).append("\n"));
- log.debug("rendered list: \n{}", buf.toString());
+ val first = new boolean[] {true};
+ bookmarkSupplier.get().forEach(x -> {
+ if(first[0]) {
+ first[0] = false;
+ } else {
+ buf.append(", ");
+ }
+ buf.append("\"").append(x.stringify()).append("\"");
+ });
+ log.debug("rendered collection: [ {} ]", buf.toString());
}
@Override
public void onRenderedValue(Object value) {
- log.debug("rendered value: \n{}", value.toString());
+ log.debug("rendered value: [ \"{}\" ]", value.toString());
}
}
diff --git a/build.sh b/build.sh
index d51b6f23fd..db0fafe41f 100644
--- a/build.sh
+++ b/build.sh
@@ -58,6 +58,7 @@ usage() {
echo "" >&2
echo "example usage:" >&2
echo "" >&2
+ echo "sh build.sh -tOd # no tests, no offline, use mvnd, released only" >&2
echo "sh build.sh -ptOdI # pull, no tests, no offline, use mvnd, no incubator" >&2
echo "sh build.sh -pctOvI # pull, clean, no tests, no offline, verbose, no incubator" >&2
echo "" >&2
diff --git a/valuetypes/asciidoc/persistence-jpa/pom.xml b/valuetypes/asciidoc/persistence-jpa/pom.xml
index 8a966c1997..d2b07970e1 100644
--- a/valuetypes/asciidoc/persistence-jpa/pom.xml
+++ b/valuetypes/asciidoc/persistence-jpa/pom.xml
@@ -30,7 +30,7 @@
</parent>
<artifactId>causeway-valuetypes-asciidoc-persistence-jpa</artifactId>
- <name>Apache Causeway Val - Asciidoctor (persistence jpa)</name>
+ <name>Apache Causeway Val - Asciidoctor (persistence JPA)</name>
<properties>
<jar-plugin.automaticModuleName>org.apache.causeway.valuetypes.asciidoc.persistence.jpa</jar-plugin.automaticModuleName>
diff --git a/valuetypes/markdown/persistence-jpa/pom.xml b/valuetypes/markdown/persistence-jpa/pom.xml
index d191d1f9ed..593b7d127a 100644
--- a/valuetypes/markdown/persistence-jpa/pom.xml
+++ b/valuetypes/markdown/persistence-jpa/pom.xml
@@ -30,7 +30,7 @@
</parent>
<artifactId>causeway-valuetypes-markdown-persistence-jpa</artifactId>
- <name>Apache Causeway Val - Markdown (persistence jpa)</name>
+ <name>Apache Causeway Val - Markdown (persistence JPA)</name>
<properties>
<jar-plugin.automaticModuleName>org.apache.causeway.valuetypes.markdown.persistence.jpa</jar-plugin.automaticModuleName>
diff --git a/valuetypes/vega/persistence-jpa/pom.xml b/valuetypes/vega/persistence-jpa/pom.xml
index c168d306eb..d8dc1c6a87 100644
--- a/valuetypes/vega/persistence-jpa/pom.xml
+++ b/valuetypes/vega/persistence-jpa/pom.xml
@@ -30,7 +30,7 @@
</parent>
<artifactId>causeway-valuetypes-vega-persistence-jpa</artifactId>
- <name>Apache Causeway Val - Vega (persistence jpa)</name>
+ <name>Apache Causeway Val - Vega (persistence JPA)</name>
<properties>
<jar-plugin.automaticModuleName>org.apache.causeway.valuetypes.vega.persistence.jpa</jar-plugin.automaticModuleName>