You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "melloware (via GitHub)" <gi...@apache.org> on 2023/06/23 12:10:55 UTC
[GitHub] [myfaces] melloware opened a new pull request, #590: MYFACES-4609: Web.xml init params evaluate for EL expressions
melloware opened a new pull request, #590:
URL: https://github.com/apache/myfaces/pull/590
This was my idea was to refactor this where the init params are being read to evaluate them for EL.
However I suspect using FacesContext here is not correct?
```java
FacesContext facesContext = FacesContext.getCurrentInstance();
return (T) facesContext.getApplication().evaluateExpressionGet(facesContext, param, Object.class);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #590: MYFACES-4609: Web.xml init params evaluate for EL expressions
Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #590:
URL: https://github.com/apache/myfaces/pull/590#issuecomment-1658342251
OK closing as wont fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #590: MYFACES-4609: Web.xml init params evaluate for EL expressions
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #590:
URL: https://github.com/apache/myfaces/pull/590#issuecomment-1658267004
i general i think its a nice feature but MyfacesConfig is currently handled AppScoped, to correctly support it, we would need to be request scoped (EL can change each request)
i would close it as wont fix for now TBH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #590: MYFACES-4609: Web.xml init params evaluate for EL expressions
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #590:
URL: https://github.com/apache/myfaces/pull/590#issuecomment-1658266092
why is it not correct use FC? not available yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware closed pull request #590: MYFACES-4609: Web.xml init params evaluate for EL expressions
Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware closed pull request #590: MYFACES-4609: Web.xml init params evaluate for EL expressions
URL: https://github.com/apache/myfaces/pull/590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org