You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/08/01 05:35:34 UTC

[kudu-CR] [docs] guide on assertions in the Java code 

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7549

Change subject: [docs] guide on assertions in the Java code
......................................................................

[docs] guide on assertions in the Java code

Added guide on using assert and Guava Preconditions in the Kudu Java
client code. That's a compilation of the information from the following
e-mail thread:

  https://lists.apache.org/thread.html/13e39d1c4e632c5fcc134097a045fe89f5a2955ac3838a48e4e38bc2@%3Cdev.kudu.apache.org%3E

Also, separated the CMake style guide from the C++ code style section.

Change-Id: I78c249021f9eb9a9a94cdf1ff1b2dae94561c2fd
---
M docs/contributing.adoc
1 file changed, 64 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/7549/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I78c249021f9eb9a9a94cdf1ff1b2dae94561c2fd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [docs] guide on assertions in the Java code

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: [docs] guide on assertions in the Java code
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78c249021f9eb9a9a94cdf1ff1b2dae94561c2fd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [docs] guide on assertions in the Java code

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: [docs] guide on assertions in the Java code
......................................................................


[docs] guide on assertions in the Java code

Added guide on using assert and Guava Preconditions in the Kudu Java
client code. That's a compilation of the information from the following
e-mail thread:

  https://lists.apache.org/thread.html/13e39d1c4e632c5fcc134097a045fe89f5a2955ac3838a48e4e38bc2@%3Cdev.kudu.apache.org%3E

Also, separated the CMake style guide from the C++ code style section.

Change-Id: I78c249021f9eb9a9a94cdf1ff1b2dae94561c2fd
Reviewed-on: http://gerrit.cloudera.org:8080/7549
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M docs/contributing.adoc
1 file changed, 64 insertions(+), 19 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Alexey Serbin: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78c249021f9eb9a9a94cdf1ff1b2dae94561c2fd
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [docs] guide on assertions in the Java code

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).

Change subject: [docs] guide on assertions in the Java code
......................................................................

[docs] guide on assertions in the Java code

Added guide on using assert and Guava Preconditions in the Kudu Java
client code. That's a compilation of the information from the following
e-mail thread:

  https://lists.apache.org/thread.html/13e39d1c4e632c5fcc134097a045fe89f5a2955ac3838a48e4e38bc2@%3Cdev.kudu.apache.org%3E

Also, separated the CMake style guide from the C++ code style section.

Change-Id: I78c249021f9eb9a9a94cdf1ff1b2dae94561c2fd
---
M docs/contributing.adoc
1 file changed, 64 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/7549/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78c249021f9eb9a9a94cdf1ff1b2dae94561c2fd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [docs] guide on assertions in the Java code

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [docs] guide on assertions in the Java code
......................................................................


Patch Set 2: Verified+1

Unrelated flakes in:
  RaftConsensusITest.TestReplicaBehaviorViaRPC
  org.apache.kudu.spark.kudu.DefaultSourceTest.Test SparkSQL StringStartsWith filters

-- 
To view, visit http://gerrit.cloudera.org:8080/7549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78c249021f9eb9a9a94cdf1ff1b2dae94561c2fd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [docs] guide on assertions in the Java code

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: [docs] guide on assertions in the Java code
......................................................................


Patch Set 1: Verified+1

Unrelated flake in RaftConsensusITest.TestElectPendingVoter

-- 
To view, visit http://gerrit.cloudera.org:8080/7549
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78c249021f9eb9a9a94cdf1ff1b2dae94561c2fd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No