You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by drigodwin <gi...@git.apache.org> on 2017/01/09 15:33:40 UTC
[GitHub] brooklyn-server pull request #509: [wip] Add Azure Location
GitHub user drigodwin opened a pull request:
https://github.com/apache/brooklyn-server/pull/509
[wip] Add Azure Location
This adds the Azure classic and Azure ARM locations from jclouds labs to the karaf features.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/drigodwin/brooklyn-server feature/jclouds-azure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/509.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #509
----
commit a892d44b7d2ec7e0ef6b322907be6c53abff4536
Author: Duncan Godwin <du...@cloudsoftcorp.com>
Date: 2017-01-09T15:32:34Z
Add Azure Location
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #509: [wip] Add Azure Location
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/509
@drigodwin looks good. In what way is this still "work in progress"?
Looking at how features are defined in https://github.com/jclouds/jclouds-karaf/blob/master/feature/src/main/resources/feature.xml, I wonder if we want to (overengineer?!) structure it like:
```
<!--
Features for providers defined in jclouds-labs, similar to the way core providers are defined in
https://github.com/jclouds/jclouds-karaf/blob/rel/jclouds-karaf-2.0.0/feature/src/main/resources/feature.xml
-->
<feature name="jclouds-labs-azurecompute" description='Components to access Azure Compute Classic' version="${jclouds.version}">
<feature version='${jclouds.version}'>jclouds-compute</feature>
<bundle>mvn:org.apache.jclouds.labs/azurecompute/${jclouds.version}</bundle>
</feature>
<feature name="jclouds-labs-azurecompute-arm" description='Components to access Azure Compute (ARM)' version="${jclouds.version}">
<feature version='${jclouds.version}'>jclouds-compute</feature>
<bundle dependency="true">mvn:org.apache.jclouds.api/oauth/${jclouds.version}</bundle>
<bundle>mvn:org.apache.jclouds.labs/azurecompute-arm/${jclouds.version}</bundle>
</feature>
```
And then include those features in the feature `brooklyn-locations-jclouds`.
---
As an aside (for different PR), we can now use the jclouds feature `jclouds-google-compute-engine` rather than us having to explicitly depend on the bundle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #509: Add Azure Location
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the issue:
https://github.com/apache/brooklyn-server/pull/509
I've tested this by deploying Tomcat to Azure classic and it worked fine, thanks @m4rkmckenna \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #509: [wip] Add Azure Location
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the issue:
https://github.com/apache/brooklyn-server/pull/509
It's still a wip as there were some oddities that emerged during testing @aledsage, they looked like they could be unrelated but thought it best if merging didn't happen until they were sorted out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #509: Add Azure Location
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/509
\U0001f44d LGTM and others have tested; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #509: Add Azure Location
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #509: [wip] Add Azure Location
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the issue:
https://github.com/apache/brooklyn-server/pull/509
@drigodwin @aledsage I tweaked the startup order in 6b90a4a this now works as expected
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---