[jira] [Work logged] (GOBBLIN-1765) Add support to sync metadata for dir in manifest based copy

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1765?focusedWorklogId=839203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839203 ]

ASF GitHub Bot logged work on GOBBLIN-1765:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jan/23 01:52
            Start Date: 14/Jan/23 01:52
    Worklog Time Spent: 10m 
      Work Description: ZihanLi58 opened a new pull request, #3624:
URL: https://github.com/apache/gobblin/pull/3624

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1765
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   We want to add support so that when user specify a dir in manifest file, we will blindly sync the metadata for that dir regardless the modification time.
   This change include:
   1. add config to support whether we want preserve mod time for dir and by default it's true
   2. Change the FileAwareInpuSTreamWriter so that during commit, when we see the output path already exist and CopyableFile is one directory, we won't rename/overwrite the target dir incase we overwrite the file that already been copied in the same job.   We still want to add this dir as copyableFile because only in this case, we can make sure publisher will be executed even there is no other file to copy and handle the metadata sync for dirs. 
   3. Change the shouldCopy method in manifest to 
     a. Always copy dir
     b. Always copy file if source has newer version
     c. Copy file is source and dst have same version but target permission is different on dst. (this is because chown won't change the modification time)
     d. never copy file if dst has newer version
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Existing unit test all pass. Also test the real manifest copy job and verify that we can sync metadata for dir without affecting the files already existed in the dir
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       4. Subject is limited to 50 characters
       5. Subject does not end with a period
       6. Subject uses the imperative mood ("add", not "adding")
       7. Body wraps at 72 characters
       8. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 839203)
    Remaining Estimate: 0h
            Time Spent: 10m

> Add support to sync metadata for dir in manifest based copy
> -----------------------------------------------------------
>
>                 Key: GOBBLIN-1765
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1765
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Add support so that if user specify a dir in manifest, we will blind sync the metadata(acls and permission) for it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)