[PR] KAFKA-20803: Demultiplex batched persister responses once ( initialize state handler) [kafka]

["Shekharrajak (via GitHub)" <gi...@apache.org>]

Shekharrajak opened a new pull request, #23976:
URL: https://github.com/apache/kafka/pull/23976

   Follow-up to https://github.com/apache/kafka/pull/22835 for [KAFKA-20803](https://issues.apache.org/jira/browse/KAFKA-20803).
   
       Remove repeated scans of batched initialize state responses.
       Build one shared PartitionResultIndex per batch and let initialize state handler  look up its result by topic ID and partition.
       It Reduce demultiplexing from O(N ^ 2) to average O(N), using O(N) temporary indexing memory while preserving payloads, errors, and retries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-20803: Demultiplex batched persister responses once ( initialize state handler) [kafka]

["Shekharrajak (via GitHub)" <gi...@apache.org>]

Shekharrajak commented on code in PR #23976:
URL: https://github.com/apache/kafka/pull/23976#discussion_r4386926755


##########
server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##########
@@ -665,55 +677,44 @@ protected void handleRequestResponse(ClientResponse response) {
 
             switch (clientResponseError) {
                 case NONE:
-                    // response can be a combined one for large number of requests
-                    // we need to deconstruct it
-                    InitializeShareGroupStateResponse combinedResponse = (InitializeShareGroupStateResponse) response.responseBody();
+                    InitializeShareGroupStateResponseData.PartitionResult partitionResult = lookupPartitionResult(response);

Review Comment:
   Similar to https://github.com/apache/kafka/pull/23971 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org