[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2912: [GOBBLIN-1072] Being more conservative on leasing containers

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2912: [GOBBLIN-1072] Being more conservative on leasing containers
URL: https://github.com/apache/incubator-gobblin/pull/2912#discussion_r389193332
 
 

 ##########
 File path: gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java
 ##########
 @@ -137,6 +154,13 @@ protected void shutDown() throws Exception {
     private final int partitionsPerContainer;
     private final int minContainers;
     private final int maxContainers;
+    private final MaxValueEvictingQueue slidingFixedWindow;
+    private final HelixDataAccessor helixDataAccessor;
+    /**
+     * A static map that keep track of an idle instance and its latest beginning idle time.
+     * If an instance is no long idle when inspected, it will be dropped from this map.
 
 Review comment:
   no long -> no longer

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services