You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Michael Osipov (Jira)" <ji...@apache.org> on 2019/10/29 13:22:00 UTC
[jira] [Comment Edited] (HTTPCLIENT-2019) Deprecate
ServiceUnavailableRetryStrategy in favor or a more generic name
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962002#comment-16962002 ]
Michael Osipov edited comment on HTTPCLIENT-2019 at 10/29/19 1:21 PM:
----------------------------------------------------------------------
I think folding into {{HttpRequestRetryStrategy}} is the best option for both with a new {{ClientExecChain}} and then deperating both interfaces, their implementations and chains. But this will need a bit more time though.
{{HttpRequestRetryStrategy}}:
{code:java}
interface HttpRequestRetryStrategy {
boolean retryRequest(IOException exception, int executionCount, HttpContext context);
boolean retryRequest(HttpResponse response, int executionCount, HttpContext context);
long getRetryInterval();
}
{code}
was (Author: michael-o):
I think folding into {{HttpRequestRetryStrategy}} is the best option for both with a new {{ClientExecChain}} and then deperating both interface, their implementations and chains. But this will need a bit more time though.
> Deprecate ServiceUnavailableRetryStrategy in favor or a more generic name
> -------------------------------------------------------------------------
>
> Key: HTTPCLIENT-2019
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2019
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient (classic)
> Affects Versions: 4.5.10, 5.0 Beta6
> Reporter: Michael Osipov
> Priority: Major
> Labels: stuck, volunteers-wanted
> Fix For: Stuck
>
>
> Based on a [discussion|http://mail-archives.apache.org/mod_mbox/hc-dev/201910.mbox/%3Cff79e9739c5aa8639ee785e6848c9e5112113ee5.camel%40apache.org%3E] on the mailing list, the name {{ServiceUnavailableRetryStrategy}} implies that this interface is only suited for HTTP status code 503, but you make handle any 3xx, 4xx, 5xx code. Therefore, this interface should be renamed to something better/more generic like {{RetryStrategy}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org