You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/07 12:58:44 UTC

[GitHub] [nifi] markobean commented on pull request #6506: NIFI-10243: allow ControlRate to throttle on combination of data rate or flowfile rate

markobean commented on PR #6506:
URL: https://github.com/apache/nifi/pull/6506#issuecomment-1305579098

   I think refactoring the inner classes is scope creep. Also, those classes are scoped as private implying there is specific intent to have them as inner classes. I recommend leaving them as-is or opening a separate ticket for further evaluation and work.
   
   Thanks for the review @thenatog. I believe all your comments have been resolved. Is this ready to be merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org