You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "deniskuzZ (via GitHub)" <gi...@apache.org> on 2023/03/27 08:49:09 UTC
[GitHub] [hive] deniskuzZ commented on a diff in pull request #4131: HIVE-27158: Store hive columns stats in puffin files for iceberg tables
deniskuzZ commented on code in PR #4131:
URL: https://github.com/apache/hive/pull/4131#discussion_r1148989152
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2207,6 +2207,8 @@ public static enum ConfVars {
"Whether to use codec pool in ORC. Disable if there are bugs with codec reuse."),
HIVE_USE_STATS_FROM("hive.use.stats.from","iceberg","Use stats from iceberg table snapshot for query " +
"planning. This has three values metastore, puffin and iceberg"),
+ HIVE_COL_STATS_SOURCE("hive.col.stats.source","metastore","Use stats from puffin file for query " +
Review Comment:
- do we support `iceberg` mode?
- please update the description - "Use stats from selected source for query planning"
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2207,6 +2207,8 @@ public static enum ConfVars {
"Whether to use codec pool in ORC. Disable if there are bugs with codec reuse."),
HIVE_USE_STATS_FROM("hive.use.stats.from","iceberg","Use stats from iceberg table snapshot for query " +
"planning. This has three values metastore, puffin and iceberg"),
+ HIVE_COL_STATS_SOURCE("hive.col.stats.source","metastore","Use stats from puffin file for query " +
Review Comment:
- do we support `iceberg` mode?
- please update the description - "Use stats from the selected source for query planning"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org