You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Enis Soztutar (JIRA)" <ji...@apache.org> on 2012/06/20 02:46:43 UTC
[jira] [Created] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Enis Soztutar created HBASE-6241:
------------------------------------
Summary: HBaseCluster interface for interacting with the cluster from system tests
Key: HBASE-6241
URL: https://issues.apache.org/jira/browse/HBASE-6241
Project: HBase
Issue Type: Sub-task
Reporter: Enis Soztutar
Assignee: Enis Soztutar
We need to abstract away the cluster interactions for system tests running on actual clusters.
MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401847#comment-13401847 ]
Enis Soztutar commented on HBASE-6241:
--------------------------------------
bq. This JIRA is a sub-task of HBASE-6201 which doesn't have patch attached.
bq. Can you clarify the above ?
Sorry, it should be HBASE-6203.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HBASE-6241:
---------------------------------
Status: Patch Available (was: Open)
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch, HBASE-6241_v4.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418668#comment-13418668 ]
Enis Soztutar commented on HBASE-6241:
--------------------------------------
Thanks Stack for the review. I put up an updated patch at RB (after some sweet time-off :) ).
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455460#comment-13455460 ]
stack commented on HBASE-6241:
------------------------------
I was trying to run tests locally but seems to fail w/ this Enis:
{code}
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:testCompile (default-testCompile) on project hbase-server: Compilation failure
[ERROR] /Users/Stack/checkouts/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java:[1053,50] unreported exception java.io.IOException; must be caught or declared to be thrown
{code}
Do you have same issue?
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch, HBASE-6241_v4.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451125#comment-13451125 ]
Enis Soztutar commented on HBASE-6241:
--------------------------------------
I think I need to rebase the patch, and incorporate the review suggestions. You were going to take a second pass, i believe. I can also break down the patch into 2, if it is too big to review properly. The reason our system tests are not converted to this is that the patch is not finalized yet. But after this, I will spend some time on converting more tests.
Also I will backport this to 0.94, and expect the community to pick up and write/convert more tests using this framework. I'll provide an overview of this issue for the developer meetup on Tuesday, and I'll attach the bits here, so that we can further discuss.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451249#comment-13451249 ]
stack commented on HBASE-6241:
------------------------------
I took a second pass (it looks great...a few more minor items you could get in another pass). No need to break it down.
Lets get it into trunk. Backport to 0.94 could be ugly. Its nice as it is here in trunk in own module.
Looking forward to Thursday chat on this (Lets have it committed before then -- smile). Good on you Enis.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456214#comment-13456214 ]
Andrew Purtell commented on HBASE-6241:
---------------------------------------
+1 on 0.94 backport, though it may be ugly. Please ping me for assistance if you like.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch, HBASE-6241_v4.patch, HBASE-6241_v5.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405066#comment-13405066 ]
stack commented on HBASE-6241:
------------------------------
Feedback up on RB Enis. Thanks.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456502#comment-13456502 ]
stack commented on HBASE-6241:
------------------------------
My commit message referred to HBASE-6201, the parent issue, rather than this one. I fixed it.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.96.0
>
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch, HBASE-6241_v4.patch, HBASE-6241_v5.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404040#comment-13404040 ]
Zhihong Ted Yu commented on HBASE-6241:
---------------------------------------
I added the following into hbase-it/pom.xml:
{code}
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-common</artifactId>
</dependency>
{code}
Otherwise I would see the following when running 'mvn verify' under hbase-it:
{code}
[ERROR] /Users/zhihyu/trunk-hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestDataIngestWithChaosMonkey.java:[29,35] cannot find symbol
[ERROR] symbol : class Bytes
[ERROR] location: package org.apache.hadoop.hbase.util
[ERROR]
[ERROR] /Users/zhihyu/trunk-hbase/hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestDataIngestWithChaosMonkey.java:[70,23] cannot find symbol
[ERROR] symbol : variable Bytes
[ERROR] location: class org.apache.hadoop.hbase.IntegrationTestDataIngestWithChaosMonkey
[ERROR] -> [Help 1]
{code}
I then saw zookeeper Watcher class not found, so I added this:
{code}
<dependency>
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
</dependency>
{code}
Then I got:
{code}
testDataIngest(org.apache.hadoop.hbase.IntegrationTestDataIngestWithChaosMonkey) Time elapsed: 7.426 sec <<< ERROR!
java.lang.NoClassDefFoundError: com/google/protobuf/InvalidProtocolBufferException
at org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:823)
{code}
...
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6241:
----------------------------------
Attachment: HBASE-6241_v1.patch
Patch from review board.
Will take a close look tomorrow.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452610#comment-13452610 ]
Enis Soztutar commented on HBASE-6241:
--------------------------------------
Thanks Stack for the review. I'll put together smt to go over for tomorrow. Let's finalize the patch, and continue building upon it.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450323#comment-13450323 ]
stack commented on HBASE-6241:
------------------------------
Enis, what do I need to do to get this in? I see r3 up on RB. I think that is what I reviewed previous. It looks like there are a few little things to address (and Sameer added a review after me). I also just added "Why not convert in-house your intergration tests to use [this patch]? If we commit it, will you?" (smile). Good on you Enis.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HBASE-6241:
---------------------------------
Attachment: HBASE-6241_v5.patch
Attaching a patch which should fix the compilation issue. Thanks Stack for trying it out.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch, HBASE-6241_v4.patch, HBASE-6241_v5.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403661#comment-13403661 ]
Enis Soztutar commented on HBASE-6241:
--------------------------------------
@Ted thanks for comments. I've addressed most of them.
I've uploaded an updated version of the patch: https://reviews.apache.org/r/5653/. I guess RB still does not post to jira.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402293#comment-13402293 ]
Zhihong Ted Yu commented on HBASE-6241:
---------------------------------------
{code}
+ private Class<?>[] getIntegrationTestClasses() {
+ //TODO: replace this with smt to find all classes in the classpath
+ //having @Category(IntegrationTests.class) annotation
{code}
See TestCheckTestClasses.findTestClasses() for example on how the above can be done.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425409#comment-13425409 ]
Enis Soztutar commented on HBASE-6241:
--------------------------------------
Updated the patch at RB, and attached another patch for documenting how to run integration tests at HBASE-6302.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456336#comment-13456336 ]
stack commented on HBASE-6241:
------------------------------
And would suggest opening new issue for the 0.94 backport.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.96.0
>
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch, HBASE-6241_v4.patch, HBASE-6241_v5.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HBASE-6241:
---------------------------------
Attachment: HBASE-6241_v4.patch
Attaching patch from RB.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch, HBASE-6241_v4.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6241:
----------------------------------
Status: Patch Available (was: Open)
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6241:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Release Note: Adds an Integration Test facilty that is run by invoking 'mvn verify'. It can run the same test on a minihbasecluster and also on an already distributed cluster. Adds a ChaosMonkey too.
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Enis for the nice new functionality. Lets get your fancy doc in next. Good stuff.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.96.0
>
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch, HBASE-6241_v4.patch, HBASE-6241_v5.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501796#comment-13501796 ]
Hudson commented on HBASE-6241:
-------------------------------
Integrated in HBase-0.94 #600 (See [https://builds.apache.org/job/HBase-0.94/600/])
HBASE-7009 Port HBaseCluster interface/tests to 0.94 (HBASE-6241) (Revision 1411998)
Result = SUCCESS
enis :
Files :
* /hbase/branches/0.94/pom.xml
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/AbstractHBaseTool.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/Threads.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClusterManager.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestDataIngestWithChaosMonkey.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestingUtility.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTests.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/LargeTests.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/MediumTests.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/SmallTests.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ipc/TestPBOnWritableRpc.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestMXBean.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestExactCounterMetric.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestMXBean.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenMasterInitializing.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/ChaosMonkey.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/StoppableImplementation.java
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.96.0
>
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch, HBASE-6241_v4.patch, HBASE-6241_v5.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402544#comment-13402544 ]
Zhihong Ted Yu commented on HBASE-6241:
---------------------------------------
{code}
+ * @return whether we are interacting with a real cluster as opposed to and in-process mini
{code}
'and' -> 'an'
For HBaseClusterManager, I see enum STATUS but don't see method which issues that command.
For HBaseTestingUtility.java:
{code}
+ } catch (Exception ex) {
+ throw new RuntimeException(ex);
+ }
{code}
The above doesn't seem necessary.
For RealHBaseCluster.java, please add license.
For waitForActiveAndReadyMaster():
{code}
+ } catch (MasterNotRunningException m) {
+ LOG.warn("Master not started yet " + m);
{code}
Does it make sense to introduce timeout since loop may wait indefinitely.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404174#comment-13404174 ]
Enis Soztutar commented on HBASE-6241:
--------------------------------------
@Ted
Thanks for trying it out. Did you run mvn verify at the top level or cd'ing into hbase-it. hbase-it depends on hbase-server, so it fetches hbase-common and other jars transitively, but you might have to do mvn install -DskipTests first.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401792#comment-13401792 ]
Zhihong Ted Yu commented on HBASE-6241:
---------------------------------------
bq. It requires HBASE-6201.
This JIRA is a sub-task of HBASE-6201 which doesn't have patch attached.
Can you clarify the above ?
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404233#comment-13404233 ]
Zhihong Ted Yu commented on HBASE-6241:
---------------------------------------
That worked:
{code}
Running org.apache.hadoop.hbase.IntegrationTestDataIngestWithChaosMonkey
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 456.531 sec
{code}
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402458#comment-13402458 ]
Zhihong Ted Yu commented on HBASE-6241:
---------------------------------------
{code}
+ cluster.abortRegionServer(selected);
+ sleep(ONE_MIN);
+ cluster.startRegionServer(servers[selected].getHostname());
+ sleep(ONE_MIN);
{code}
Is there better way to detect the stop of region server has completed ?
{code}
+ public static enum ServiceType {
{code}
Should job/task tracker be in the enum as well ?
{code}
+ public abstract boolean signal(ServiceType service, String signal, String hostname) throws IOException;
{code}
Line length should be 100 chars or shorter.
For HBaseCluster.java, remove year in license.
{code}
+ * @return Name of master that just went down.
+ */
+ public abstract String waitOnMaster(final int serverNumber);
{code}
If no enum argument is planned to be added, the method can be renamed as waitOnMasterToStop().
{code}
+ public void restoreInitialState() throws IOException {
{code}
How about restoring to one of the ClusterStatus previously captured by getClusterStatus() ? (future enhancement)
I think getInitialClusterStatus() and getClusterStatus() can be unified into one method with enum indicating the type of status.
{code}
+ * @return Index into List of {@link MiniHBaseCluster#getRegionServerThreads()}
+ * of HRS carrying .META.. Returns -1 if none found.
+ */
+ public abstract int getServerWith(byte[] regionName) throws IOException;
{code}
The return value isn't just for .META. server. Its javadoc, should be improved - considering MiniHBaseCluster being a subclass of HBaseCluster.
More review comments to follow.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HBASE-6241:
---------------------------------
Status: Open (was: Patch Available)
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch, HBASE-6241_v4.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404330#comment-13404330 ]
Enis Soztutar commented on HBASE-6241:
--------------------------------------
Forgot to mention that patch at RB addresses all of the Ted's comments above, except:
bq. If no enum argument is planned to be added, the method can be renamed as waitOnMasterToStop().
renamed methods like waitForMasterToStop()
bq. + public void restoreInitialState() throws IOException {
bq. How about restoring to one of the ClusterStatus previously captured by getClusterStatus() ? (future enhancement)
bq. I think getInitialClusterStatus() and getClusterStatus() can be unified into one method with enum indicating the type of status.
Now, we have restoreInitialStatus(), and restoreClusterStatus(ClusterStatus desiredStatus). The former just calls the latter with the result from getInitialClusterStatus()
bq. For HBaseTestingUtility.java:
{code}
+ } catch (Exception ex) {
+ throw new RuntimeException(ex);
+ }
{code}
Moved the exception catching an throwing into the constructor.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404236#comment-13404236 ]
stack commented on HBASE-6241:
------------------------------
@Enis I commented over in https://reviews.apache.org/r/5653/ Some questions. Good stuff though.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch, HBASE-6241_v1.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6241) HBaseCluster interface for
interacting with the cluster from system tests
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HBASE-6241:
---------------------------------
Attachment: HBASE-6241_v0.2.patch
Attaching an patch for early view. I am still polishing stuff, but bulk of the patch is pretty much done. i'll upload the candidate for review version once it is done. This is based on the patch for HBASE-6053, but does not include TestRegionRebalance changes. It requires HBASE-6201.
Some high-level notes on the patch:
- uses hbase-it module, and adds a new test there called IntegrationTestDataIngestWithChaosMonkey. This class runs LoadTestTool with a chaos monkey(http://www.codinghorror.com/blog/2011/04/working-with-the-chaos-monkey.html). Chaos monkey is very sipmle right now, just does selects a random RS, kills and restarts it.
- Introduces HBaseCluster, RealHBaseCluster and changes MiniHBaseCluster to extends HBaseCluster.
- Adds a ClusterManager interface, and a default HBase shell scripts based HBaseClusterManager. These are internal-classses and tests does not directly refer to them, so we can improve on them, maybe add another implementation when BIGTOP-635 is done.
- I've tested the patch on a mini-cluster as well as a 8-node cluster.
- Adds an IntegrationTestsDriver class as a driver for running integration tests from command line. You can do "bin/hbase --config <hbase_conf_dir> o.a.h.h.ITD" to run all the integration tests on a real cluster. mvn verify runs them on mini cluster. I'll open another issue for mvn verify on real clusters.
> HBaseCluster interface for interacting with the cluster from system tests
> --------------------------------------------------------------------------
>
> Key: HBASE-6241
> URL: https://issues.apache.org/jira/browse/HBASE-6241
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HBASE-6241_v0.2.patch
>
>
> We need to abstract away the cluster interactions for system tests running on actual clusters.
> MiniHBaseCluster and RealHBaseCluster should both implement this interface, and system tests should work with both.
> I'll split Devaraj's patch in HBASE-6053 for the initial version.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira