You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/05/14 09:18:27 UTC
Review Request 67109: Did not omit frame pointers in debug builds in
stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67109/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
This patch prevents the compiler from omitting frame pointers for
debug builds which can lead to a better debugging or profiling
experience.
Since having this flag turned on can disable certain optimizations we
do not enable it in non-debug builds. This can lead to minor
deviations in runtime behavior when combing release and debug flags
(e.g., when combining `--enable-debug` with `--enable-optimize`, or
with the cmake build type `RelWithDebInfo`), but still should give the
best possible build for pure release builds, and allow a reasonable
developer experience when debugging/profiling.
Diffs
-----
3rdparty/stout/configure.ac 5a8c023de63e6b96b128cdfb472859a6f3e6ede5
Diff: https://reviews.apache.org/r/67109/diff/1/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 67109: Disabled omission of frame pointers in debug
builds in stout.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67109/
-----------------------------------------------------------
(Updated May 14, 2018, 8:38 p.m.)
Review request for mesos, Benjamin Mahler and James Peach.
Summary (updated)
-----------------
Disabled omission of frame pointers in debug builds in stout.
Bugs: MESOS-8908
https://issues.apache.org/jira/browse/MESOS-8908
Repository: mesos
Description
-------
This patch prevents the compiler from omitting frame pointers for
debug builds which can lead to a better debugging or profiling
experience.
Since having this flag turned on can disable certain optimizations we
do not enable it in non-debug builds. This can lead to minor
deviations in runtime behavior when combing release and debug flags
(e.g., when combining `--enable-debug` with `--enable-optimize`, or
with the cmake build type `RelWithDebInfo`), but still should give the
best possible build for pure release builds, and allow a reasonable
developer experience when debugging/profiling.
Diffs
-----
3rdparty/stout/configure.ac 5a8c023de63e6b96b128cdfb472859a6f3e6ede5
Diff: https://reviews.apache.org/r/67109/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 67109: Did not omit frame pointers in debug builds
in stout.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67109/#review203030
-----------------------------------------------------------
Ship it!
Nit: I'd make the subject "Do not omit ..."
- James Peach
On May 14, 2018, 9:18 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67109/
> -----------------------------------------------------------
>
> (Updated May 14, 2018, 9:18 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Bugs: MESOS-8908
> https://issues.apache.org/jira/browse/MESOS-8908
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch prevents the compiler from omitting frame pointers for
> debug builds which can lead to a better debugging or profiling
> experience.
>
> Since having this flag turned on can disable certain optimizations we
> do not enable it in non-debug builds. This can lead to minor
> deviations in runtime behavior when combing release and debug flags
> (e.g., when combining `--enable-debug` with `--enable-optimize`, or
> with the cmake build type `RelWithDebInfo`), but still should give the
> best possible build for pure release builds, and allow a reasonable
> developer experience when debugging/profiling.
>
>
> Diffs
> -----
>
> 3rdparty/stout/configure.ac 5a8c023de63e6b96b128cdfb472859a6f3e6ede5
>
>
> Diff: https://reviews.apache.org/r/67109/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>