[GitHub] maropu commented on a change in pull request #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #23867: [SPARK-26965][SQL] Makes ElementAt nullability more precise
URL: https://github.com/apache/spark/pull/23867#discussion_r259653812
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
 ##########
 @@ -281,10 +290,29 @@ case class GetArrayItem(child: Expression, ordinal: Expression)
 }
 
 /**
- * Common base class for [[GetMapValue]] and [[ElementAt]].
+ * Common trait for [[GetMapValue]] and [[ElementAt]].
  */
+trait GetMapValueUtil extends BinaryExpression with ImplicitCastInputTypes {
 
 Review comment:
   It seems `BinaryExpression.nullSafeCodeGen` is used in the other place?
   https://github.com/apache/spark/blob/2d2fb34b93a55af7e45191c8974bb55a0ed76e87/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala#L326

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org