You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/06 04:14:05 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29006: [SPARK-32058][BUILD][SQL][test-hive1.2][FOLLOWUP] Set hadoop 2.7.4 for hive 1.2 profile

HyukjinKwon commented on a change in pull request #29006:
URL: https://github.com/apache/spark/pull/29006#discussion_r449970573



##########
File path: dev/run-tests-jenkins.py
##########
@@ -183,6 +183,7 @@ def main():
     # Switch the Hive profile based on the PR title:
     if "test-hive1.2" in ghprb_pull_title:
         os.environ["AMPLAB_JENKINS_BUILD_HIVE_PROFILE"] = "hive1.2"
+        os.environ["AMPLAB_JENKINS_BUILD_PROFILE"] = "hadoop2.7"

Review comment:
       Let's don't do this but rather fail with an explicit error message. It will be confusing what Hive 1.2 uses its Hadoop version as.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org