You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Richard Ding (JIRA)" <ji...@apache.org> on 2014/03/26 18:45:17 UTC
[jira] [Created] (HBASE-10842) Some logger not declared static
final
Richard Ding created HBASE-10842:
------------------------------------
Summary: Some logger not declared static final
Key: HBASE-10842
URL: https://issues.apache.org/jira/browse/HBASE-10842
Project: HBase
Issue Type: Improvement
Affects Versions: 0.96.1.1, 0.98.1
Reporter: Richard Ding
Assignee: Richard Ding
Priority: Minor
In a few of source files, the logger is defined as
{code}
private final Log LOG = LogFactory.getLog(MyClass.class);
{code}
This should be changed to static final.
One question is about the following declaration:
{code}
private final Log LOG = LogFactory.getLog(this.getClass());
{code}
In this form, the logger can be shared by derived classes. But one will get NPE when logging in methods that are invoked inside the constructors.
--
This message was sent by Atlassian JIRA
(v6.2#6252)