You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/22 09:33:02 UTC
[GitHub] [lucene-solr] donnerpeter opened a new pull request #2413: LUCENE-9799: Hunspell: don't check second-level affixes when the first level isn't a continuation
donnerpeter opened a new pull request #2413:
URL: https://github.com/apache/lucene-solr/pull/2413
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Two-stage affix removal is quite expensive and can result on O(n^2) performance, especially with many zero affixes like in French
# Solution
Don't go to the second stage if on the first one we've removed an affix which definitely isn't compatible with any other affix on the second stage; create a set of all continuation flags to check that quickly.
# Tests
No new tests. `TestPerformance.de/fr` show about 2x speedups.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] rmuir merged pull request #2413: LUCENE-9799: Hunspell: don't check second-level affixes when the first level isn't a continuation
Posted by GitBox <gi...@apache.org>.
rmuir merged pull request #2413:
URL: https://github.com/apache/lucene-solr/pull/2413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2413: LUCENE-9799: Hunspell: don't check second-level affixes when the first level isn't a continuation
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2413:
URL: https://github.com/apache/lucene-solr/pull/2413#discussion_r580104444
##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -78,9 +78,6 @@
private static final int DEFAULT_FLAGS = 65510;
static final char HIDDEN_FLAG = (char) 65511; // called 'ONLYUPCASEFLAG' in Hunspell
- // TODO: really for suffixes we should reverse the automaton and run them backwards
- private static final String PREFIX_CONDITION_REGEX = "%s.*";
- private static final String SUFFIX_CONDITION_REGEX = ".*%s";
Review comment:
Inlined to the use site to make method signature shorter to still fit one line :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org